From e82c2285a4f7b494fec5285e2489ff961bbc571f Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Wed, 28 Sep 2022 15:18:33 +0200 Subject: [PATCH] Restore some metrics in call_perf_tests.cc Switch "min_test_bitrate_", "bitrate_stats_min_transmit_bitrate" and "bitrate_stats_without_min_transmit_bitrate" from kKilobitsPerSecond to kUnitless to avoid conversion to bytesPerSecond in the Chrome Perf Dasboard. Bug: b/246095034, webrtc:14479 Change-Id: Id8a4a104dd351670aec63415087d8825acaa3d48 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277221 Reviewed-by: Danil Chapovalov Commit-Queue: Artem Titov Reviewed-by: Ilya Nikolaevskiy Cr-Commit-Position: refs/heads/main@{#38236} --- call/call_perf_tests.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/call/call_perf_tests.cc b/call/call_perf_tests.cc index 3b6db5d626..3d8041eb5f 100644 --- a/call/call_perf_tests.cc +++ b/call/call_perf_tests.cc @@ -738,7 +738,7 @@ void CallPerfTest::TestMinTransmitBitrate(bool pad_to_min_bitrate) { std::string("bitrate_stats_") + (pad_to_min_bitrate_ ? "min_transmit_bitrate" : "without_min_transmit_bitrate"), - "bitrate_kbps", bitrate_kbps_list_, Unit::kKilobitsPerSecond, + "bitrate_kbps", bitrate_kbps_list_, Unit::kUnitless, ImprovementDirection::kNeitherIsBetter); } @@ -1017,7 +1017,7 @@ void CallPerfTest::TestMinAudioVideoBitrate(int test_bitrate_from, << "Minimum supported bitrate out of the test scope"; GetGlobalMetricsLogger()->LogSingleValueMetric( "min_test_bitrate_", "min_bitrate", last_passed_test_bitrate, - Unit::kKilobitsPerSecond, ImprovementDirection::kNeitherIsBetter); + Unit::kUnitless, ImprovementDirection::kNeitherIsBetter); } void OnCallsCreated(Call* sender_call, Call* receiver_call) override {