admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add _[no]red suffix to RampUpTests.

Browse Source 
For the RampUpTest.UpDownUpAbsSendTimeSimulcastRedRtx and
RampUpTest.UpDownUpTransportSequenceNumberRtx [1,2], the generated metric names
are the same:

- ramp_up_down_up_3streams_rtx.first_rampup
- ramp_up_down_up_3streams_rtx.second_rampup
- ramp_up_down_up_3streams_rtx.rampdown

So only one of the two tests (whichever ran last) has its metrics reported to
the perf dashboard, while the others has its metrics ignored.

[1] https://webrtc.googlesource.com/src/+/master/call/rampup_tests.cc#571
[2] https://webrtc.googlesource.com/src/+/master/call/rampup_tests.cc#579

Bug: webrtc:8691
Change-Id: I632dfe32d3b4729f1b0233c44d03c2894ee8c027
Reviewed-on: https://webrtc-review.googlesource.com/36941
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21499}
This commit is contained in:
Edward Lemur 2018-01-04 19:44:54 +01:00 committed by Commit Bot
parent 9e19403d10
commit dd3987fa3e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
call/rampup_tests.cc
View File

@ -461,7 +461,9 @@ std::string RampUpDownUpTester::GetModifierString() const {
str += "_";
}
str += (rtx_ ? "" : "no");
str += "rtx";
str += "rtx_";
str += (red_ ? "" : "no");
str += "red";
return str;
}