From dd3987fa3e1e5247c31a0dcebe7b1648b87597cd Mon Sep 17 00:00:00 2001 From: Edward Lemur Date: Thu, 4 Jan 2018 19:44:54 +0100 Subject: [PATCH] Add _[no]red suffix to RampUpTests. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For the RampUpTest.UpDownUpAbsSendTimeSimulcastRedRtx and RampUpTest.UpDownUpTransportSequenceNumberRtx [1,2], the generated metric names are the same: - ramp_up_down_up_3streams_rtx.first_rampup - ramp_up_down_up_3streams_rtx.second_rampup - ramp_up_down_up_3streams_rtx.rampdown So only one of the two tests (whichever ran last) has its metrics reported to the perf dashboard, while the others has its metrics ignored. [1] https://webrtc.googlesource.com/src/+/master/call/rampup_tests.cc#571 [2] https://webrtc.googlesource.com/src/+/master/call/rampup_tests.cc#579 Bug: webrtc:8691 Change-Id: I632dfe32d3b4729f1b0233c44d03c2894ee8c027 Reviewed-on: https://webrtc-review.googlesource.com/36941 Reviewed-by: Patrik Höglund Reviewed-by: Henrik Andreassson Commit-Queue: Edward Lemur Cr-Commit-Position: refs/heads/master@{#21499} --- call/rampup_tests.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/call/rampup_tests.cc b/call/rampup_tests.cc index 1d584195d2..d0354168cf 100644 --- a/call/rampup_tests.cc +++ b/call/rampup_tests.cc @@ -461,7 +461,9 @@ std::string RampUpDownUpTester::GetModifierString() const { str += "_"; } str += (rtx_ ? "" : "no"); - str += "rtx"; + str += "rtx_"; + str += (red_ ? "" : "no"); + str += "red"; return str; }