admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mac: Remove unused GetQuickTimeVersion().

Browse Source 
The function uses a deprecated function and is unused, so delete it.

BUG=6027
NOTRY=true

Review-Url: https://codereview.webrtc.org/2114013002
Cr-Commit-Position: refs/heads/master@{#13400}
This commit is contained in:
thakis 2016-07-06 11:03:14 -07:00 committed by Commit bot
parent 0cf208aa28
commit d7d3e05ca6
3 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
webrtc/base/macutils.cc
View File

@ -129,18 +129,6 @@ MacOSVersionName GetOSVersionName() {
return kMacOSNewer;
}
bool GetQuickTimeVersion(std::string* out) {
int ver;
if (!GetGestalt(gestaltQuickTimeVersion, &ver)) {
return false;
}
std::stringstream ss;
ss << std::hex << ver;
*out = ss.str();
return true;
}
bool RunAppleScript(const std::string& script) {
// TODO(thaloun): Add a .mm file that contains something like this:
// NSString source from script

1
webrtc/base/macutils.h
View File

@ -44,7 +44,6 @@ enum MacOSVersionName {
};
MacOSVersionName GetOSVersionName();
bool GetQuickTimeVersion(std::string* version);
// Runs the given apple script. Only supports scripts that does not
// require user interaction.

6
webrtc/base/macutils_unittest.cc
View File

@ -17,12 +17,6 @@ TEST(MacUtilsTest, GetOsVersionName) {
EXPECT_NE(rtc::kMacOSUnknown, ver);
}
TEST(MacUtilsTest, GetQuickTimeVersion) {
std::string version;
EXPECT_TRUE(rtc::GetQuickTimeVersion(&version));
LOG(LS_INFO) << "GetQuickTimeVersion " << version;
}
TEST(MacUtilsTest, RunAppleScriptCompileError) {
std::string script("set value to to 5");
EXPECT_FALSE(rtc::RunAppleScript(script));