From d7d3e05ca6cef3226ff0034e25b78fe699360bd5 Mon Sep 17 00:00:00 2001 From: thakis Date: Wed, 6 Jul 2016 11:03:14 -0700 Subject: [PATCH] mac: Remove unused GetQuickTimeVersion(). The function uses a deprecated function and is unused, so delete it. BUG=6027 NOTRY=true Review-Url: https://codereview.webrtc.org/2114013002 Cr-Commit-Position: refs/heads/master@{#13400} --- webrtc/base/macutils.cc | 12 ------------ webrtc/base/macutils.h | 1 - webrtc/base/macutils_unittest.cc | 6 ------ 3 files changed, 19 deletions(-) diff --git a/webrtc/base/macutils.cc b/webrtc/base/macutils.cc index 72ca5cb349..3a07b815c9 100644 --- a/webrtc/base/macutils.cc +++ b/webrtc/base/macutils.cc @@ -129,18 +129,6 @@ MacOSVersionName GetOSVersionName() { return kMacOSNewer; } -bool GetQuickTimeVersion(std::string* out) { - int ver; - if (!GetGestalt(gestaltQuickTimeVersion, &ver)) { - return false; - } - - std::stringstream ss; - ss << std::hex << ver; - *out = ss.str(); - return true; -} - bool RunAppleScript(const std::string& script) { // TODO(thaloun): Add a .mm file that contains something like this: // NSString source from script diff --git a/webrtc/base/macutils.h b/webrtc/base/macutils.h index e3a42563d2..78c442f0e9 100644 --- a/webrtc/base/macutils.h +++ b/webrtc/base/macutils.h @@ -44,7 +44,6 @@ enum MacOSVersionName { }; MacOSVersionName GetOSVersionName(); -bool GetQuickTimeVersion(std::string* version); // Runs the given apple script. Only supports scripts that does not // require user interaction. diff --git a/webrtc/base/macutils_unittest.cc b/webrtc/base/macutils_unittest.cc index 7150bf3550..e295eaae08 100644 --- a/webrtc/base/macutils_unittest.cc +++ b/webrtc/base/macutils_unittest.cc @@ -17,12 +17,6 @@ TEST(MacUtilsTest, GetOsVersionName) { EXPECT_NE(rtc::kMacOSUnknown, ver); } -TEST(MacUtilsTest, GetQuickTimeVersion) { - std::string version; - EXPECT_TRUE(rtc::GetQuickTimeVersion(&version)); - LOG(LS_INFO) << "GetQuickTimeVersion " << version; -} - TEST(MacUtilsTest, RunAppleScriptCompileError) { std::string script("set value to to 5"); EXPECT_FALSE(rtc::RunAppleScript(script));