admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."

Browse Source 
This reverts commit 6e81567d291f973769a2b8b19801bfd71cc603ad.

Reason for revert: Testing reason, this CL will break Chromium FYI bots but now that it is landed I can start a Chromium CL and pin this WebRTC version.

Original change's description:
> Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
> 
> This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed
> 
> Original change's description:
> > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
> >
> > In order to land the component build support in Chromium, it is
> > easier to turn on symbols export every time that is_component_build=true
> > instead of setting rtc_enable_symbol_export=is_component_build in
> > Chromium (since is_component_build is not available in .gn).
> >
> > rtc_enable_symbol_export is still kept in the mix in order to turn
> > on symbol exports in any case a shared library will be added to the
> > WebRTC build.
> >
> > Bug: webrtc:9419
> > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#29540}
> 
> TBR: kwiberg@webrtc.org
> Bug: webrtc:9419
> Change-Id: Ic35347636984b360e0bee01f2a3e37efd351e3d5
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157976
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29590}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: Ic6e4fe081d0d6ef1249bc3f933c00c0e54cca554
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9419
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158064
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29591}
This commit is contained in:
Mirko Bonadei 2019-10-23 16:56:13 +00:00 committed by Commit Bot
parent 6e81567d29
commit d7bf5c56b6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BUILD.gn
View File

@ -111,7 +111,7 @@ config("common_inherited_config") {
cflags = [] cflags = []
ldflags = [] ldflags = []
if (rtc_enable_symbol_export || is_component_build) { if (rtc_enable_symbol_export) {
defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ] defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ]
} }