From d7bf5c56b69b7a34f13802f100940e38ee47bad4 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Wed, 23 Oct 2019 16:56:13 +0000 Subject: [PATCH] Revert "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." This reverts commit 6e81567d291f973769a2b8b19801bfd71cc603ad. Reason for revert: Testing reason, this CL will break Chromium FYI bots but now that it is landed I can start a Chromium CL and pin this WebRTC version. Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg > > Commit-Queue: Mirko Bonadei > > Cr-Commit-Position: refs/heads/master@{#29540} > > TBR: kwiberg@webrtc.org > Bug: webrtc:9419 > Change-Id: Ic35347636984b360e0bee01f2a3e37efd351e3d5 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157976 > Commit-Queue: Mirko Bonadei > Reviewed-by: Mirko Bonadei > Cr-Commit-Position: refs/heads/master@{#29590} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: Ic6e4fe081d0d6ef1249bc3f933c00c0e54cca554 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158064 Reviewed-by: Mirko Bonadei Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#29591} --- BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILD.gn b/BUILD.gn index 9a1ab25440..a0eda8f72e 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -111,7 +111,7 @@ config("common_inherited_config") { cflags = [] ldflags = [] - if (rtc_enable_symbol_export || is_component_build) { + if (rtc_enable_symbol_export) { defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ] }