admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removing assert error when we fail to create a connection for a ping from an unknown address.

Browse Source 
It may happen in some legitimate scenarios.
For example a turn port may have had a refresh request timeout, so it won't create a new connection for a ping from an unknown address.

R=deadbeef@webrtc.org

Review URL: https://codereview.webrtc.org/2327233002 .

Cr-Commit-Position: refs/heads/master@{#14173}
This commit is contained in:
Honghai Zhang 2016-09-09 20:47:53 -07:00
parent ed0b0dba15
commit d5fff5040c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
webrtc/p2p/base/p2ptransportchannel.cc
View File

@ -648,7 +648,8 @@ void P2PTransportChannel::OnUnknownAddress(
Connection* connection =
port->CreateConnection(remote_candidate, PortInterface::ORIGIN_THIS_PORT);
if (!connection) {
ASSERT(false);
// This could happen in some scenarios. For example, a TurnPort may have
// had a refresh request timeout, so it won't create connections.
port->SendBindingErrorResponse(stun_msg, address, STUN_ERROR_SERVER_ERROR,
STUN_ERROR_REASON_SERVER_ERROR);
return;