From d5fff5040c691b02486c407c41616c6009483bf1 Mon Sep 17 00:00:00 2001 From: Honghai Zhang Date: Fri, 9 Sep 2016 20:47:53 -0700 Subject: [PATCH] Removing assert error when we fail to create a connection for a ping from an unknown address. It may happen in some legitimate scenarios. For example a turn port may have had a refresh request timeout, so it won't create a new connection for a ping from an unknown address. R=deadbeef@webrtc.org Review URL: https://codereview.webrtc.org/2327233002 . Cr-Commit-Position: refs/heads/master@{#14173} --- webrtc/p2p/base/p2ptransportchannel.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/webrtc/p2p/base/p2ptransportchannel.cc b/webrtc/p2p/base/p2ptransportchannel.cc index f5f8a665aa..9f25cd2755 100644 --- a/webrtc/p2p/base/p2ptransportchannel.cc +++ b/webrtc/p2p/base/p2ptransportchannel.cc @@ -648,7 +648,8 @@ void P2PTransportChannel::OnUnknownAddress( Connection* connection = port->CreateConnection(remote_candidate, PortInterface::ORIGIN_THIS_PORT); if (!connection) { - ASSERT(false); + // This could happen in some scenarios. For example, a TurnPort may have + // had a refresh request timeout, so it won't create connections. port->SendBindingErrorResponse(stun_msg, address, STUN_ERROR_SERVER_ERROR, STUN_ERROR_REASON_SERVER_ERROR); return;