admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify stats poller stop in PC level framework

Browse Source 
Bug: webrtc:10138
Change-Id: I9f6c2fd4109439df813b2bd0a47466eefb64defd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149065
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28876}
This commit is contained in:
Artem Titov 2019-08-14 14:17:31 +02:00 committed by Commit Bot
parent 6950b3088c
commit cc96db6de2
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/pc/e2e/peer_connection_quality_test.cc
View File

@ -51,7 +51,6 @@ constexpr int kFrameworkUsedThreads = 2;
constexpr int kMaxVideoAnalyzerThreads = 8; constexpr int kMaxVideoAnalyzerThreads = 8;
constexpr TimeDelta kStatsUpdateInterval = TimeDelta::Seconds<1>(); constexpr TimeDelta kStatsUpdateInterval = TimeDelta::Seconds<1>();
constexpr TimeDelta kStatsPollingStopTimeout = TimeDelta::Seconds<1>();
constexpr TimeDelta kAliveMessageLogInterval = TimeDelta::Seconds<30>(); constexpr TimeDelta kAliveMessageLogInterval = TimeDelta::Seconds<30>();
@ -367,15 +366,10 @@ void PeerConnectionE2EQualityTest::Run(RunParams run_params) {
done.Wait(run_params.run_duration.ms()); done.Wait(run_params.run_duration.ms());
} }
rtc::Event stats_polling_stopped; task_queue_->SendTask([this]() {
task_queue_->PostTask([&stats_polling_stopped, this]() {
RTC_DCHECK_RUN_ON(task_queue_.get()); RTC_DCHECK_RUN_ON(task_queue_.get());
stats_polling_task_.Stop(); stats_polling_task_.Stop();
stats_polling_stopped.Set();
}); });
bool no_timeout = stats_polling_stopped.Wait(kStatsPollingStopTimeout.ms());
RTC_CHECK(no_timeout) << "Failed to stop Stats polling after "
<< kStatsPollingStopTimeout.seconds() << " seconds.";
// We need to detach AEC dumping from peers, because dump uses |task_queue_| // We need to detach AEC dumping from peers, because dump uses |task_queue_|
// inside. // inside.