From cc96db6de20131be1248e4a237e30a5a6d59cae8 Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Wed, 14 Aug 2019 14:17:31 +0200 Subject: [PATCH] Simplify stats poller stop in PC level framework Bug: webrtc:10138 Change-Id: I9f6c2fd4109439df813b2bd0a47466eefb64defd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149065 Reviewed-by: Mirko Bonadei Commit-Queue: Artem Titov Cr-Commit-Position: refs/heads/master@{#28876} --- test/pc/e2e/peer_connection_quality_test.cc | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/test/pc/e2e/peer_connection_quality_test.cc b/test/pc/e2e/peer_connection_quality_test.cc index 03fa31fdf4..4d7afb66cc 100644 --- a/test/pc/e2e/peer_connection_quality_test.cc +++ b/test/pc/e2e/peer_connection_quality_test.cc @@ -51,7 +51,6 @@ constexpr int kFrameworkUsedThreads = 2; constexpr int kMaxVideoAnalyzerThreads = 8; constexpr TimeDelta kStatsUpdateInterval = TimeDelta::Seconds<1>(); -constexpr TimeDelta kStatsPollingStopTimeout = TimeDelta::Seconds<1>(); constexpr TimeDelta kAliveMessageLogInterval = TimeDelta::Seconds<30>(); @@ -367,15 +366,10 @@ void PeerConnectionE2EQualityTest::Run(RunParams run_params) { done.Wait(run_params.run_duration.ms()); } - rtc::Event stats_polling_stopped; - task_queue_->PostTask([&stats_polling_stopped, this]() { + task_queue_->SendTask([this]() { RTC_DCHECK_RUN_ON(task_queue_.get()); stats_polling_task_.Stop(); - stats_polling_stopped.Set(); }); - bool no_timeout = stats_polling_stopped.Wait(kStatsPollingStopTimeout.ms()); - RTC_CHECK(no_timeout) << "Failed to stop Stats polling after " - << kStatsPollingStopTimeout.seconds() << " seconds."; // We need to detach AEC dumping from peers, because dump uses |task_queue_| // inside.