admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update/delete old TODOs

Browse Source 
Bug: webrtc:10198
Change-Id: I226768c2a6bd97ffcd0638e5bc6a1c286b71815f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267704
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37435}
This commit is contained in:
Niels Möller 2022-07-05 10:52:21 +02:00 committed by WebRTC LUCI CQ
parent fb9fbdf395
commit c8152fe4a8
6 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
media/engine/simulcast_encoder_adapter_unittest.cc
View File

@ -986,7 +986,6 @@ TEST_F(TestSimulcastEncoderAdapterFake,
EXPECT_FALSE(adapter_->GetEncoderInfo().supports_native_handle);
}
// TODO(nisse): Reuse definition in webrtc/test/fake_texture_handle.h.
class FakeNativeBufferI420 : public VideoFrameBuffer {
public:
FakeNativeBufferI420(int width, int height, bool allow_to_i420)

2
media/engine/webrtc_video_engine.cc
View File

@ -2269,7 +2269,7 @@ void WebRtcVideoChannel::WebRtcVideoSendStream::SetCodec(
parameters_.codec_settings = codec_settings;
// TODO(nisse): Avoid recreation, it should be enough to call
// TODO(bugs.webrtc.org/8830): Avoid recreation, it should be enough to call
// ReconfigureEncoder.
RTC_LOG(LS_INFO) << "RecreateWebRtcStream (send) because of SetCodec.";
RecreateWebRtcStream();

1
media/engine/webrtc_video_engine_unittest.cc
View File

@ -158,7 +158,6 @@ bool HasAnyRtxCodec(const std::vector<cricket::VideoCodec>& codecs) {
return false;
}
// TODO(nisse): Duplicated in call.cc.
const int* FindKeyByValue(const std::map<int, int>& m, int v) {
for (const auto& kv : m) {
if (kv.second == v)

5
modules/rtp_rtcp/include/receive_statistics.h
View File

@ -43,8 +43,9 @@ class StreamStatistician {
// Returns average over the stream life time.
virtual absl::optional<int> GetFractionLostInPercent() const = 0;
// TODO(nisse): Delete, migrate users to the above the GetStats method.
// Gets received stream data counters (includes reset counter values).
// TODO(bugs.webrtc.org/10679): Delete, migrate users to the above GetStats
// method (and extend RtpReceiveStats if needed).
// Gets receive stream data counters.
virtual StreamDataCounters GetReceiveStreamDataCounters() const = 0;
virtual uint32_t BitrateReceived() const = 0;

3
modules/rtp_rtcp/source/forward_error_correction.h
View File

@ -75,9 +75,6 @@ class ForwardErrorCorrection {
};
// Used for the input to DecodeFec().
//
// TODO(nisse): Delete class, instead passing `is_fec` and `pkt` as separate
// arguments.
class ReceivedPacket : public SortablePacket {
public:
ReceivedPacket();

2
modules/rtp_rtcp/source/nack_rtx_unittest.cc
View File

@ -151,8 +151,6 @@ class RtpRtcpRtxNackTest : public ::testing::Test {
rtp_rtcp_module_->SetStartTimestamp(111111);
// Used for NACK processing.
// TODO(nisse): Unclear on which side? It's confusing to use a
// single rtp_rtcp module for both send and receive side.
rtp_rtcp_module_->SetRemoteSSRC(kTestSsrc);
rtp_rtcp_module_->SetRtxSendPayloadType(kRtxPayloadType, kPayloadType);