From c8152fe4a8d62323d01924679dca8acc602ccf48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Tue, 5 Jul 2022 10:52:21 +0200 Subject: [PATCH] Update/delete old TODOs Bug: webrtc:10198 Change-Id: I226768c2a6bd97ffcd0638e5bc6a1c286b71815f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267704 Commit-Queue: Niels Moller Reviewed-by: Harald Alvestrand Cr-Commit-Position: refs/heads/main@{#37435} --- media/engine/simulcast_encoder_adapter_unittest.cc | 1 - media/engine/webrtc_video_engine.cc | 2 +- media/engine/webrtc_video_engine_unittest.cc | 1 - modules/rtp_rtcp/include/receive_statistics.h | 5 +++-- modules/rtp_rtcp/source/forward_error_correction.h | 3 --- modules/rtp_rtcp/source/nack_rtx_unittest.cc | 2 -- 6 files changed, 4 insertions(+), 10 deletions(-) diff --git a/media/engine/simulcast_encoder_adapter_unittest.cc b/media/engine/simulcast_encoder_adapter_unittest.cc index 159a5207c2..1962a590cd 100644 --- a/media/engine/simulcast_encoder_adapter_unittest.cc +++ b/media/engine/simulcast_encoder_adapter_unittest.cc @@ -986,7 +986,6 @@ TEST_F(TestSimulcastEncoderAdapterFake, EXPECT_FALSE(adapter_->GetEncoderInfo().supports_native_handle); } -// TODO(nisse): Reuse definition in webrtc/test/fake_texture_handle.h. class FakeNativeBufferI420 : public VideoFrameBuffer { public: FakeNativeBufferI420(int width, int height, bool allow_to_i420) diff --git a/media/engine/webrtc_video_engine.cc b/media/engine/webrtc_video_engine.cc index d5b5fa4318..f089881f67 100644 --- a/media/engine/webrtc_video_engine.cc +++ b/media/engine/webrtc_video_engine.cc @@ -2269,7 +2269,7 @@ void WebRtcVideoChannel::WebRtcVideoSendStream::SetCodec( parameters_.codec_settings = codec_settings; - // TODO(nisse): Avoid recreation, it should be enough to call + // TODO(bugs.webrtc.org/8830): Avoid recreation, it should be enough to call // ReconfigureEncoder. RTC_LOG(LS_INFO) << "RecreateWebRtcStream (send) because of SetCodec."; RecreateWebRtcStream(); diff --git a/media/engine/webrtc_video_engine_unittest.cc b/media/engine/webrtc_video_engine_unittest.cc index b61edfab9e..b54443103c 100644 --- a/media/engine/webrtc_video_engine_unittest.cc +++ b/media/engine/webrtc_video_engine_unittest.cc @@ -158,7 +158,6 @@ bool HasAnyRtxCodec(const std::vector& codecs) { return false; } -// TODO(nisse): Duplicated in call.cc. const int* FindKeyByValue(const std::map& m, int v) { for (const auto& kv : m) { if (kv.second == v) diff --git a/modules/rtp_rtcp/include/receive_statistics.h b/modules/rtp_rtcp/include/receive_statistics.h index f973b7cf4f..827fd3a7a8 100644 --- a/modules/rtp_rtcp/include/receive_statistics.h +++ b/modules/rtp_rtcp/include/receive_statistics.h @@ -43,8 +43,9 @@ class StreamStatistician { // Returns average over the stream life time. virtual absl::optional GetFractionLostInPercent() const = 0; - // TODO(nisse): Delete, migrate users to the above the GetStats method. - // Gets received stream data counters (includes reset counter values). + // TODO(bugs.webrtc.org/10679): Delete, migrate users to the above GetStats + // method (and extend RtpReceiveStats if needed). + // Gets receive stream data counters. virtual StreamDataCounters GetReceiveStreamDataCounters() const = 0; virtual uint32_t BitrateReceived() const = 0; diff --git a/modules/rtp_rtcp/source/forward_error_correction.h b/modules/rtp_rtcp/source/forward_error_correction.h index d07bb8e422..0ebe1c5091 100644 --- a/modules/rtp_rtcp/source/forward_error_correction.h +++ b/modules/rtp_rtcp/source/forward_error_correction.h @@ -75,9 +75,6 @@ class ForwardErrorCorrection { }; // Used for the input to DecodeFec(). - // - // TODO(nisse): Delete class, instead passing `is_fec` and `pkt` as separate - // arguments. class ReceivedPacket : public SortablePacket { public: ReceivedPacket(); diff --git a/modules/rtp_rtcp/source/nack_rtx_unittest.cc b/modules/rtp_rtcp/source/nack_rtx_unittest.cc index 2f14820f6f..d0617f3804 100644 --- a/modules/rtp_rtcp/source/nack_rtx_unittest.cc +++ b/modules/rtp_rtcp/source/nack_rtx_unittest.cc @@ -151,8 +151,6 @@ class RtpRtcpRtxNackTest : public ::testing::Test { rtp_rtcp_module_->SetStartTimestamp(111111); // Used for NACK processing. - // TODO(nisse): Unclear on which side? It's confusing to use a - // single rtp_rtcp module for both send and receive side. rtp_rtcp_module_->SetRemoteSSRC(kTestSsrc); rtp_rtcp_module_->SetRtxSendPayloadType(kRtxPayloadType, kPayloadType);