admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "disallow pairing ICE-TCP with a local ip address"

Browse Source 
This reverts commit 712ebbb5b73baf30f11711efdceb6f08248fac38.
There is apparently more usage in the wild than anticipated.

Bug: chromium:1068705
Change-Id: If2f3907e509570d305670206d8d3724413964208
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174420
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31163}
This commit is contained in:
Philipp Hancke 2020-05-05 06:51:13 +02:00 committed by Commit Bot
parent dad6a940e1
commit c1aaf4cb38
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pc/jsep_transport_controller.cc
View File

@ -59,13 +59,6 @@ webrtc::RTCError VerifyCandidate(const cricket::Candidate& cand) {
}
}
// Disallow ICE-TCP with a private IP address.
if (cand.protocol() == cricket::TCP_PROTOCOL_NAME &&
cand.address().IsPrivateIP()) {
return webrtc::RTCError(webrtc::RTCErrorType::INVALID_PARAMETER,
"candidate is TCP and has a private IP address");
}
return webrtc::RTCError::OK();
}