From c1aaf4cb381d99f19472ac3c39ecfd9ade51c416 Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Tue, 5 May 2020 06:51:13 +0200 Subject: [PATCH] Revert "disallow pairing ICE-TCP with a local ip address" This reverts commit 712ebbb5b73baf30f11711efdceb6f08248fac38. There is apparently more usage in the wild than anticipated. Bug: chromium:1068705 Change-Id: If2f3907e509570d305670206d8d3724413964208 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174420 Commit-Queue: Harald Alvestrand Reviewed-by: Harald Alvestrand Cr-Commit-Position: refs/heads/master@{#31163} --- pc/jsep_transport_controller.cc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/pc/jsep_transport_controller.cc b/pc/jsep_transport_controller.cc index 39451d5c06..a7e1b876fe 100644 --- a/pc/jsep_transport_controller.cc +++ b/pc/jsep_transport_controller.cc @@ -59,13 +59,6 @@ webrtc::RTCError VerifyCandidate(const cricket::Candidate& cand) { } } - // Disallow ICE-TCP with a private IP address. - if (cand.protocol() == cricket::TCP_PROTOCOL_NAME && - cand.address().IsPrivateIP()) { - return webrtc::RTCError(webrtc::RTCErrorType::INVALID_PARAMETER, - "candidate is TCP and has a private IP address"); - } - return webrtc::RTCError::OK(); }