admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't use result of "field_trial::FindFullName" as string reference.

Browse Source 
"field_trial::FindFullName" can return "std::string()" which should not
be referenced by the caller.

Review URL: https://codereview.webrtc.org/1238943003

Cr-Commit-Position: refs/heads/master@{#9594}
This commit is contained in:
jbauch 2015-07-16 04:05:52 -07:00 committed by Commit bot
parent a9b4c32052
commit bd38428089
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
talk/media/webrtc/webrtcvideocapturer.cc
View File

@ -265,7 +265,7 @@ bool WebRtcVideoCapturer::SetApplyRotation(bool enable) {
// calls, can't take lock.
DCHECK(module_);
const std::string& group_name =
const std::string group_name =
webrtc::field_trial::FindFullName("WebRTC-CVO");
if (group_name == "Disabled") {

2
talk/media/webrtc/webrtcvideoengine2.cc
View File

@ -154,7 +154,7 @@ bool CodecIsInternallySupported(const std::string& codec_name) {
return true;
}
if (CodecNamesEq(codec_name, kVp9CodecName)) {
const std::string& group_name =
const std::string group_name =
webrtc::field_trial::FindFullName("WebRTC-SupportVP9");
return group_name == "Enabled" || group_name == "EnabledByFlag";
}