From bd3842808996dbb85007242214352f1e6ebd3d17 Mon Sep 17 00:00:00 2001 From: jbauch Date: Thu, 16 Jul 2015 04:05:52 -0700 Subject: [PATCH] Don't use result of "field_trial::FindFullName" as string reference. "field_trial::FindFullName" can return "std::string()" which should not be referenced by the caller. Review URL: https://codereview.webrtc.org/1238943003 Cr-Commit-Position: refs/heads/master@{#9594} --- talk/media/webrtc/webrtcvideocapturer.cc | 2 +- talk/media/webrtc/webrtcvideoengine2.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/talk/media/webrtc/webrtcvideocapturer.cc b/talk/media/webrtc/webrtcvideocapturer.cc index 8ef920e98a..f8c373db36 100644 --- a/talk/media/webrtc/webrtcvideocapturer.cc +++ b/talk/media/webrtc/webrtcvideocapturer.cc @@ -265,7 +265,7 @@ bool WebRtcVideoCapturer::SetApplyRotation(bool enable) { // calls, can't take lock. DCHECK(module_); - const std::string& group_name = + const std::string group_name = webrtc::field_trial::FindFullName("WebRTC-CVO"); if (group_name == "Disabled") { diff --git a/talk/media/webrtc/webrtcvideoengine2.cc b/talk/media/webrtc/webrtcvideoengine2.cc index 121db147cc..91997954d6 100644 --- a/talk/media/webrtc/webrtcvideoengine2.cc +++ b/talk/media/webrtc/webrtcvideoengine2.cc @@ -154,7 +154,7 @@ bool CodecIsInternallySupported(const std::string& codec_name) { return true; } if (CodecNamesEq(codec_name, kVp9CodecName)) { - const std::string& group_name = + const std::string group_name = webrtc::field_trial::FindFullName("WebRTC-SupportVP9"); return group_name == "Enabled" || group_name == "EnabledByFlag"; }