admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Adding -Wno-deprecated-declarations to declarations deprecated in iOS 10"

Browse Source 
This reverts commit 2a9dbe6e7e722cf069b72ccff0051b1517706996.

Reason for revert: The fix does not help, it still fails at runtime

Original change's description:
> Adding -Wno-deprecated-declarations to declarations deprecated in iOS 10
>
> This CL will unblock the Chromium Roll while deprecated declarations
> will be removed from the WebRTC codebase.
>
> Bug: webrtc:8570
> Change-Id: I55cf78040758369ce45176cf0a00df50a87eb972
> No-Try: True
> Reviewed-on: https://webrtc-review.googlesource.com/25641
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20858}

No-Try: True
Bug: webrtc:8570
Change-Id: Ib17ed05f8f239912661281329ecab175c23491d6
Reviewed-on: https://webrtc-review.googlesource.com/25964
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20890}
This commit is contained in:
Oleh Prypin 2017-11-27 10:54:16 +00:00 committed by Commit Bot
parent 06483ca0ce
commit b8ff8f7d40
2 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/video_capture/BUILD.gn
View File

@ -89,9 +89,6 @@ if (!build_with_chromium) {
if (is_ios || is_mac) {
rtc_source_set("video_capture_internal_impl_objc") {
# TODO(bugs.webrtc.org/8570): Remove -Wno-deprecated-declarations flag
# when the code will be updated.
cflags_objcc = [ "-Wno-deprecated-declarations" ]
visibility = [ ":video_capture_internal_impl" ]
configs += [ ":video_capture_internal_impl_warnings_config" ]

12
sdk/BUILD.gn
View File

@ -148,9 +148,6 @@ if (is_ios || is_mac) {
}
rtc_static_library("video_objc") {
# TODO(bugs.webrtc.org/8570): Remove -Wno-deprecated-declarations flag
# when the code will be updated.
cflags_objcc = [ "-Wno-deprecated-declarations" ]
sources = [
"objc/Framework/Classes/Video/AVCaptureSession+DevicePosition.h",
"objc/Framework/Classes/Video/AVCaptureSession+DevicePosition.mm",
@ -209,9 +206,6 @@ if (is_ios || is_mac) {
rtc_static_library("ui_objc") {
if (is_ios) {
# TODO(bugs.webrtc.org/8570): Remove -Wno-deprecated-declarations flag
# when the code will be updated.
cflags_objc = [ "-Wno-deprecated-declarations" ]
sources = [
"objc/Framework/Classes/UI/RTCCameraPreviewView.m",
"objc/Framework/Classes/UI/RTCEAGLVideoView.m",
@ -271,9 +265,6 @@ if (is_ios || is_mac) {
}
rtc_static_library("peerconnection_objc") {
# TODO(bugs.webrtc.org/8570): Remove -Wno-deprecated-declarations flag
# when the code will be updated.
cflags_objc = [ "-Wno-deprecated-declarations" ]
sources = [
"objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource+Private.h",
"objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource.mm",
@ -619,9 +610,6 @@ if (is_ios || is_mac) {
!(use_ios_simulator &&
# The tests crash on these simulator versions:
(ios_sdk_version == "10.0" || ios_sdk_version == "10.1"))) {
# TODO(bugs.webrtc.org/8570): Remove -Wno-deprecated-declarations flag
# when the code will be updated.
cflags_objcc = [ "-Wno-deprecated-declarations" ]
sources +=
[ "objc/Framework/UnitTests/RTCCameraVideoCapturerTests.mm" ]
}