From b8ff8f7d4016512172b2b1fe4561ea9b18f20036 Mon Sep 17 00:00:00 2001 From: Oleh Prypin Date: Mon, 27 Nov 2017 10:54:16 +0000 Subject: [PATCH] Revert "Adding -Wno-deprecated-declarations to declarations deprecated in iOS 10" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 2a9dbe6e7e722cf069b72ccff0051b1517706996. Reason for revert: The fix does not help, it still fails at runtime Original change's description: > Adding -Wno-deprecated-declarations to declarations deprecated in iOS 10 > > This CL will unblock the Chromium Roll while deprecated declarations > will be removed from the WebRTC codebase. > > Bug: webrtc:8570 > Change-Id: I55cf78040758369ce45176cf0a00df50a87eb972 > No-Try: True > Reviewed-on: https://webrtc-review.googlesource.com/25641 > Commit-Queue: Mirko Bonadei > Reviewed-by: Patrik Höglund > Cr-Commit-Position: refs/heads/master@{#20858} No-Try: True Bug: webrtc:8570 Change-Id: Ib17ed05f8f239912661281329ecab175c23491d6 Reviewed-on: https://webrtc-review.googlesource.com/25964 Reviewed-by: Mirko Bonadei Reviewed-by: Oleh Prypin Commit-Queue: Oleh Prypin Cr-Commit-Position: refs/heads/master@{#20890} --- modules/video_capture/BUILD.gn | 3 --- sdk/BUILD.gn | 12 ------------ 2 files changed, 15 deletions(-) diff --git a/modules/video_capture/BUILD.gn b/modules/video_capture/BUILD.gn index 58bdcf8369..31a4b65a3a 100644 --- a/modules/video_capture/BUILD.gn +++ b/modules/video_capture/BUILD.gn @@ -89,9 +89,6 @@ if (!build_with_chromium) { if (is_ios || is_mac) { rtc_source_set("video_capture_internal_impl_objc") { - # TODO(bugs.webrtc.org/8570): Remove -Wno-deprecated-declarations flag - # when the code will be updated. - cflags_objcc = [ "-Wno-deprecated-declarations" ] visibility = [ ":video_capture_internal_impl" ] configs += [ ":video_capture_internal_impl_warnings_config" ] diff --git a/sdk/BUILD.gn b/sdk/BUILD.gn index 0d03dc2ea3..40eb3fb049 100644 --- a/sdk/BUILD.gn +++ b/sdk/BUILD.gn @@ -148,9 +148,6 @@ if (is_ios || is_mac) { } rtc_static_library("video_objc") { - # TODO(bugs.webrtc.org/8570): Remove -Wno-deprecated-declarations flag - # when the code will be updated. - cflags_objcc = [ "-Wno-deprecated-declarations" ] sources = [ "objc/Framework/Classes/Video/AVCaptureSession+DevicePosition.h", "objc/Framework/Classes/Video/AVCaptureSession+DevicePosition.mm", @@ -209,9 +206,6 @@ if (is_ios || is_mac) { rtc_static_library("ui_objc") { if (is_ios) { - # TODO(bugs.webrtc.org/8570): Remove -Wno-deprecated-declarations flag - # when the code will be updated. - cflags_objc = [ "-Wno-deprecated-declarations" ] sources = [ "objc/Framework/Classes/UI/RTCCameraPreviewView.m", "objc/Framework/Classes/UI/RTCEAGLVideoView.m", @@ -271,9 +265,6 @@ if (is_ios || is_mac) { } rtc_static_library("peerconnection_objc") { - # TODO(bugs.webrtc.org/8570): Remove -Wno-deprecated-declarations flag - # when the code will be updated. - cflags_objc = [ "-Wno-deprecated-declarations" ] sources = [ "objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource+Private.h", "objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource.mm", @@ -619,9 +610,6 @@ if (is_ios || is_mac) { !(use_ios_simulator && # The tests crash on these simulator versions: (ios_sdk_version == "10.0" || ios_sdk_version == "10.1"))) { - # TODO(bugs.webrtc.org/8570): Remove -Wno-deprecated-declarations flag - # when the code will be updated. - cflags_objcc = [ "-Wno-deprecated-declarations" ] sources += [ "objc/Framework/UnitTests/RTCCameraVideoCapturerTests.mm" ] }