admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor global variables to be immutable

Browse Source 
Bug: None
Change-Id: I764018705df668f83e9d8ac90766aa6b06c44614
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321182
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40816}
This commit is contained in:
Emil Lundmark 2023-09-22 17:53:19 +02:00 committed by WebRTC LUCI CQ
parent 7d81e18ac0
commit b7fca15fd4
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
experiments/field_trials.py
View File

@ -9,7 +9,7 @@
# be found in the AUTHORS file in the root of the source tree.
import sys
from typing import Set
from typing import FrozenSet
import argparse
import dataclasses
@ -28,12 +28,13 @@ class FieldTrial:
# As per the policy in `g3doc/field-trials.md`, all field trials should be
# registered in the container below. Please keep the keys sorted.
REGISTERED_FIELD_TRIALS: Set[FieldTrial] = {
REGISTERED_FIELD_TRIALS: FrozenSet[FieldTrial] = frozenset([
FieldTrial(''), # TODO(bugs.webrtc.org/14154): Populate
}
])
def registry_header(field_trials: Set[FieldTrial] = None) -> str:
def registry_header(
field_trials: FrozenSet[FieldTrial] = REGISTERED_FIELD_TRIALS) -> str:
"""Generates a C++ header with all field trial keys.
Args:
@ -64,8 +65,6 @@ def registry_header(field_trials: Set[FieldTrial] = None) -> str:
#endif // GEN_REGISTERED_FIELD_TRIALS_H_
<BLANKLINE>
"""
if not field_trials:
field_trials = REGISTERED_FIELD_TRIALS
registered_keys = [f.key for f in field_trials]
keys = '\n'.join(f' "{k}",' for k in sorted(registered_keys))
return ('// This file was automatically generated. Do not edit.\n'