From b7fca15fd4602208f8aed5b6ceca41af8dc6f991 Mon Sep 17 00:00:00 2001 From: Emil Lundmark Date: Fri, 22 Sep 2023 17:53:19 +0200 Subject: [PATCH] Refactor global variables to be immutable Bug: None Change-Id: I764018705df668f83e9d8ac90766aa6b06c44614 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321182 Reviewed-by: Harald Alvestrand Reviewed-by: Jeremy Leconte Commit-Queue: Emil Lundmark Cr-Commit-Position: refs/heads/main@{#40816} --- experiments/field_trials.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/experiments/field_trials.py b/experiments/field_trials.py index 51534612dc..eb7d7bebd3 100755 --- a/experiments/field_trials.py +++ b/experiments/field_trials.py @@ -9,7 +9,7 @@ # be found in the AUTHORS file in the root of the source tree. import sys -from typing import Set +from typing import FrozenSet import argparse import dataclasses @@ -28,12 +28,13 @@ class FieldTrial: # As per the policy in `g3doc/field-trials.md`, all field trials should be # registered in the container below. Please keep the keys sorted. -REGISTERED_FIELD_TRIALS: Set[FieldTrial] = { +REGISTERED_FIELD_TRIALS: FrozenSet[FieldTrial] = frozenset([ FieldTrial(''), # TODO(bugs.webrtc.org/14154): Populate -} +]) -def registry_header(field_trials: Set[FieldTrial] = None) -> str: +def registry_header( + field_trials: FrozenSet[FieldTrial] = REGISTERED_FIELD_TRIALS) -> str: """Generates a C++ header with all field trial keys. Args: @@ -64,8 +65,6 @@ def registry_header(field_trials: Set[FieldTrial] = None) -> str: #endif // GEN_REGISTERED_FIELD_TRIALS_H_ """ - if not field_trials: - field_trials = REGISTERED_FIELD_TRIALS registered_keys = [f.key for f in field_trials] keys = '\n'.join(f' "{k}",' for k in sorted(registered_keys)) return ('// This file was automatically generated. Do not edit.\n'