admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update TODOs to the correct format.

Browse Source 
Some TODOs that where added in https://webrtc-review.googlesource.com/c/src/+/365001 do not follow the correct format
https://webrtc.googlesource.com/src/+/refs/heads/main/g3doc/style-guide.md#comments. This CL updates the incorrect TODOs.

Also updated some comments as they referred to ntp timestamps, when the timestamp is utc.

Bug: None
Change-Id: I1661f6f57c9fa5f66e5b92f154007c34854923c6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/365162
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Olov Brändström <brandstrom@google.com>
Cr-Commit-Position: refs/heads/main@{#43214}
This commit is contained in:
Olov Brändström 2024-10-09 21:07:43 +02:00 committed by WebRTC LUCI CQ
parent 518bd61cec
commit b74268e0cf
5 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
audio/channel_receive.h
View File

@ -67,11 +67,11 @@ struct CallReceiveStatistics {
// Note that the timestamps below correspond to the time elapsed since the // Note that the timestamps below correspond to the time elapsed since the
// Unix epoch. // Unix epoch.
// https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict* // https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict*
// TODO: bugs.webrtc.org/372393493: timestamps should use the type Timestamp, // TODO: bugs.webrtc.org/372393493 - timestamps should use the type Timestamp,
// not int64_t. // not int64_t.
std::optional<int64_t> last_sender_report_timestamp_ms; std::optional<int64_t> last_sender_report_timestamp_ms;
// TODO: bugs.webrtc.org/370535296: Remove the ntp arrival timestamp when // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked
// linked issue is fixed. // issue is fixed.
std::optional<int64_t> last_sender_report_utc_timestamp_ms; std::optional<int64_t> last_sender_report_utc_timestamp_ms;
std::optional<int64_t> last_sender_report_remote_utc_timestamp_ms; std::optional<int64_t> last_sender_report_remote_utc_timestamp_ms;
uint64_t sender_reports_packets_sent = 0; uint64_t sender_reports_packets_sent = 0;

4
call/audio_receive_stream.h
View File

@ -101,8 +101,8 @@ class AudioReceiveStreamInterface : public MediaReceiveStreamInterface {
// Remote outbound stats derived by the received RTCP sender reports. // Remote outbound stats derived by the received RTCP sender reports.
// https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict* // https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict*
std::optional<int64_t> last_sender_report_timestamp_ms; std::optional<int64_t> last_sender_report_timestamp_ms;
// TODO: bugs.webrtc.org/370535296: Remove the ntp arrival timestamp when // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked
// linked issue is fixed. // issue is fixed.
std::optional<int64_t> last_sender_report_utc_timestamp_ms; std::optional<int64_t> last_sender_report_utc_timestamp_ms;
std::optional<int64_t> last_sender_report_remote_utc_timestamp_ms; std::optional<int64_t> last_sender_report_remote_utc_timestamp_ms;
uint64_t sender_reports_packets_sent = 0; uint64_t sender_reports_packets_sent = 0;

4
call/video_receive_stream.h
View File

@ -176,8 +176,8 @@ class VideoReceiveStreamInterface : public MediaReceiveStreamInterface {
// Remote outbound stats derived by the received RTCP sender reports. // Remote outbound stats derived by the received RTCP sender reports.
// https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict* // https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict*
std::optional<int64_t> last_sender_report_timestamp_ms; std::optional<int64_t> last_sender_report_timestamp_ms;
// TODO: bugs.webrtc.org/370535296: Remove the ntp arrival timestamp when // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked
// linked issue is fixed. // issue is fixed.
std::optional<int64_t> last_sender_report_utc_timestamp_ms; std::optional<int64_t> last_sender_report_utc_timestamp_ms;
std::optional<int64_t> last_sender_report_remote_utc_timestamp_ms; std::optional<int64_t> last_sender_report_remote_utc_timestamp_ms;
uint32_t sender_reports_packets_sent = 0; uint32_t sender_reports_packets_sent = 0;

6
media/base/media_channel.h
View File

@ -482,11 +482,11 @@ struct MediaReceiverInfo {
// Remote outbound stats derived by the received RTCP sender reports. // Remote outbound stats derived by the received RTCP sender reports.
// https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict* // https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict*
// TODO: bugs.webrtc.org/372393493: timestamps should use the type Timestamp, // TODO: bugs.webrtc.org/372393493 - timestamps should use the type Timestamp,
// not int64_t. // not int64_t.
std::optional<int64_t> last_sender_report_timestamp_ms; std::optional<int64_t> last_sender_report_timestamp_ms;
// TODO: bugs.webrtc.org/370535296: Remove the ntp arrival timestamp when // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked
// linked issue is fixed. // issue is fixed.
std::optional<int64_t> last_sender_report_utc_timestamp_ms; std::optional<int64_t> last_sender_report_utc_timestamp_ms;
std::optional<int64_t> last_sender_report_remote_utc_timestamp_ms; std::optional<int64_t> last_sender_report_remote_utc_timestamp_ms;
uint64_t sender_reports_packets_sent = 0; uint64_t sender_reports_packets_sent = 0;

2
modules/rtp_rtcp/source/rtp_rtcp_interface.h
View File

@ -149,7 +149,7 @@ class RtpRtcpInterface : public RtcpFeedbackSenderInterface {
// Arrival timestamp (enviroment clock) for the last received RTCP SR. // Arrival timestamp (enviroment clock) for the last received RTCP SR.
Timestamp last_arrival_timestamp = Timestamp::Zero(); Timestamp last_arrival_timestamp = Timestamp::Zero();
// Arrival NTP timestamp for the last received RTCP SR. // Arrival NTP timestamp for the last received RTCP SR.
// TODO: bugs.webrtc.org/370535296: Remove the ntp arrival timestamp when // TODO: bugs.webrtc.org/370535296 - Remove the ntp arrival timestamp when
// linked issue is fixed. // linked issue is fixed.
NtpTime last_arrival_ntp_timestamp; NtpTime last_arrival_ntp_timestamp;
// Received (a.k.a., remote) NTP timestamp for the last received RTCP SR. // Received (a.k.a., remote) NTP timestamp for the last received RTCP SR.