From b74268e0cf5fdd9f6d152247d4f092d747557701 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Olov=20Br=C3=A4ndstr=C3=B6m?= Date: Wed, 9 Oct 2024 21:07:43 +0200 Subject: [PATCH] Update TODOs to the correct format. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some TODOs that where added in https://webrtc-review.googlesource.com/c/src/+/365001 do not follow the correct format https://webrtc.googlesource.com/src/+/refs/heads/main/g3doc/style-guide.md#comments. This CL updates the incorrect TODOs. Also updated some comments as they referred to ntp timestamps, when the timestamp is utc. Bug: None Change-Id: I1661f6f57c9fa5f66e5b92f154007c34854923c6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/365162 Reviewed-by: Henrik Andreassson Reviewed-by: Danil Chapovalov Commit-Queue: Olov Brändström Cr-Commit-Position: refs/heads/main@{#43214} --- audio/channel_receive.h | 6 +++--- call/audio_receive_stream.h | 4 ++-- call/video_receive_stream.h | 4 ++-- media/base/media_channel.h | 6 +++--- modules/rtp_rtcp/source/rtp_rtcp_interface.h | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/audio/channel_receive.h b/audio/channel_receive.h index afac2944ca..ab6ce531d6 100644 --- a/audio/channel_receive.h +++ b/audio/channel_receive.h @@ -67,11 +67,11 @@ struct CallReceiveStatistics { // Note that the timestamps below correspond to the time elapsed since the // Unix epoch. // https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict* - // TODO: bugs.webrtc.org/372393493: timestamps should use the type Timestamp, + // TODO: bugs.webrtc.org/372393493 - timestamps should use the type Timestamp, // not int64_t. std::optional last_sender_report_timestamp_ms; - // TODO: bugs.webrtc.org/370535296: Remove the ntp arrival timestamp when - // linked issue is fixed. + // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked + // issue is fixed. std::optional last_sender_report_utc_timestamp_ms; std::optional last_sender_report_remote_utc_timestamp_ms; uint64_t sender_reports_packets_sent = 0; diff --git a/call/audio_receive_stream.h b/call/audio_receive_stream.h index f66abdff3c..8056e9c0d9 100644 --- a/call/audio_receive_stream.h +++ b/call/audio_receive_stream.h @@ -101,8 +101,8 @@ class AudioReceiveStreamInterface : public MediaReceiveStreamInterface { // Remote outbound stats derived by the received RTCP sender reports. // https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict* std::optional last_sender_report_timestamp_ms; - // TODO: bugs.webrtc.org/370535296: Remove the ntp arrival timestamp when - // linked issue is fixed. + // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked + // issue is fixed. std::optional last_sender_report_utc_timestamp_ms; std::optional last_sender_report_remote_utc_timestamp_ms; uint64_t sender_reports_packets_sent = 0; diff --git a/call/video_receive_stream.h b/call/video_receive_stream.h index fe27ec1fba..9de6f43156 100644 --- a/call/video_receive_stream.h +++ b/call/video_receive_stream.h @@ -176,8 +176,8 @@ class VideoReceiveStreamInterface : public MediaReceiveStreamInterface { // Remote outbound stats derived by the received RTCP sender reports. // https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict* std::optional last_sender_report_timestamp_ms; - // TODO: bugs.webrtc.org/370535296: Remove the ntp arrival timestamp when - // linked issue is fixed. + // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked + // issue is fixed. std::optional last_sender_report_utc_timestamp_ms; std::optional last_sender_report_remote_utc_timestamp_ms; uint32_t sender_reports_packets_sent = 0; diff --git a/media/base/media_channel.h b/media/base/media_channel.h index a6d90f3b1c..73d7015ab4 100644 --- a/media/base/media_channel.h +++ b/media/base/media_channel.h @@ -482,11 +482,11 @@ struct MediaReceiverInfo { // Remote outbound stats derived by the received RTCP sender reports. // https://w3c.github.io/webrtc-stats/#remoteoutboundrtpstats-dict* - // TODO: bugs.webrtc.org/372393493: timestamps should use the type Timestamp, + // TODO: bugs.webrtc.org/372393493 - timestamps should use the type Timestamp, // not int64_t. std::optional last_sender_report_timestamp_ms; - // TODO: bugs.webrtc.org/370535296: Remove the ntp arrival timestamp when - // linked issue is fixed. + // TODO: bugs.webrtc.org/370535296 - Remove the utc timestamp when linked + // issue is fixed. std::optional last_sender_report_utc_timestamp_ms; std::optional last_sender_report_remote_utc_timestamp_ms; uint64_t sender_reports_packets_sent = 0; diff --git a/modules/rtp_rtcp/source/rtp_rtcp_interface.h b/modules/rtp_rtcp/source/rtp_rtcp_interface.h index 85152357e1..1ae3a312d2 100644 --- a/modules/rtp_rtcp/source/rtp_rtcp_interface.h +++ b/modules/rtp_rtcp/source/rtp_rtcp_interface.h @@ -149,7 +149,7 @@ class RtpRtcpInterface : public RtcpFeedbackSenderInterface { // Arrival timestamp (enviroment clock) for the last received RTCP SR. Timestamp last_arrival_timestamp = Timestamp::Zero(); // Arrival NTP timestamp for the last received RTCP SR. - // TODO: bugs.webrtc.org/370535296: Remove the ntp arrival timestamp when + // TODO: bugs.webrtc.org/370535296 - Remove the ntp arrival timestamp when // linked issue is fixed. NtpTime last_arrival_ntp_timestamp; // Received (a.k.a., remote) NTP timestamp for the last received RTCP SR.