admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused misspelled function

Browse Source 
Bug: webrtc:358039777
Change-Id: I5573a8ab40a42663cfc2d24576b90e1100972e7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/363942
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43165}
This commit is contained in:
Fanny Linderborg 2024-10-02 09:15:28 +02:00 committed by WebRTC LUCI CQ
parent f75ab82b46
commit b63c05d1cc
3 changed files with 3 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
video/corruption_detection/corruption_classifier.cc
View File

@ -59,18 +59,6 @@ double CorruptionClassifier::CalculateCorruptionProbability(
return 1 / (1 + std::exp(-config->growth_rate * (loss - config->midpoint))); return 1 / (1 + std::exp(-config->growth_rate * (loss - config->midpoint)));
} }
// TODO: bugs.webrtc.org/358039777 - Remove this function when Google
// downstream projects start using the correctly spelled function.
double CorruptionClassifier::CalculateCorruptionProbablility(
rtc::ArrayView<const FilteredSample> filtered_original_samples,
rtc::ArrayView<const FilteredSample> filtered_compressed_samples,
int luma_threshold,
int chroma_threshold) const {
return CalculateCorruptionProbability(filtered_original_samples,
filtered_compressed_samples,
luma_threshold, chroma_threshold);
}
// The score is calculated according to the following formula : // The score is calculated according to the following formula :
// //
// score = (sum_i max{(|original_i - compressed_i| - threshold, 0)^2}) / N // score = (sum_i max{(|original_i - compressed_i| - threshold, 0)^2}) / N

8
video/corruption_detection/corruption_classifier.h
View File

@ -47,14 +47,6 @@ class CorruptionClassifier {
int luma_threshold, int luma_threshold,
int chroma_threshold) const; int chroma_threshold) const;
// TODO: bugs.webrtc.org/358039777 - Remove this function when Google
// downstream projects start using the correctly spelled function.
double CalculateCorruptionProbablility(
rtc::ArrayView<const FilteredSample> filtered_original_samples,
rtc::ArrayView<const FilteredSample> filtered_compressed_samples,
int luma_threshold,
int chroma_threshold) const;
private: private:
struct ScalarConfig { struct ScalarConfig {
float scale_factor; float scale_factor;

4
video/corruption_detection/frame_instrumentation_evaluation.cc
View File

@ -89,8 +89,8 @@ std::optional<double> GetCorruptionScore(const FrameInstrumentationData& data,
// classifier should we use? What input parameters should it have? // classifier should we use? What input parameters should it have?
CorruptionClassifier classifier(2.5); CorruptionClassifier classifier(2.5);
return classifier.CalculateCorruptionProbablility( return classifier.CalculateCorruptionProbability(data_samples, samples,
data_samples, samples, data.luma_error_threshold, data.luma_error_threshold,
data.chroma_error_threshold); data.chroma_error_threshold);
} }