From b63c05d1cc6da001fdcf1c79344c8f30b4ace8ee Mon Sep 17 00:00:00 2001 From: Fanny Linderborg Date: Wed, 2 Oct 2024 09:15:28 +0200 Subject: [PATCH] Remove unused misspelled function MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:358039777 Change-Id: I5573a8ab40a42663cfc2d24576b90e1100972e7b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/363942 Reviewed-by: Erik Språng Commit-Queue: Fanny Linderborg Cr-Commit-Position: refs/heads/main@{#43165} --- video/corruption_detection/corruption_classifier.cc | 12 ------------ video/corruption_detection/corruption_classifier.h | 8 -------- .../frame_instrumentation_evaluation.cc | 6 +++--- 3 files changed, 3 insertions(+), 23 deletions(-) diff --git a/video/corruption_detection/corruption_classifier.cc b/video/corruption_detection/corruption_classifier.cc index d9ead1f746..686eb753a4 100644 --- a/video/corruption_detection/corruption_classifier.cc +++ b/video/corruption_detection/corruption_classifier.cc @@ -59,18 +59,6 @@ double CorruptionClassifier::CalculateCorruptionProbability( return 1 / (1 + std::exp(-config->growth_rate * (loss - config->midpoint))); } -// TODO: bugs.webrtc.org/358039777 - Remove this function when Google -// downstream projects start using the correctly spelled function. -double CorruptionClassifier::CalculateCorruptionProbablility( - rtc::ArrayView filtered_original_samples, - rtc::ArrayView filtered_compressed_samples, - int luma_threshold, - int chroma_threshold) const { - return CalculateCorruptionProbability(filtered_original_samples, - filtered_compressed_samples, - luma_threshold, chroma_threshold); -} - // The score is calculated according to the following formula : // // score = (sum_i max{(|original_i - compressed_i| - threshold, 0)^2}) / N diff --git a/video/corruption_detection/corruption_classifier.h b/video/corruption_detection/corruption_classifier.h index 538007b75b..8df7f28c23 100644 --- a/video/corruption_detection/corruption_classifier.h +++ b/video/corruption_detection/corruption_classifier.h @@ -47,14 +47,6 @@ class CorruptionClassifier { int luma_threshold, int chroma_threshold) const; - // TODO: bugs.webrtc.org/358039777 - Remove this function when Google - // downstream projects start using the correctly spelled function. - double CalculateCorruptionProbablility( - rtc::ArrayView filtered_original_samples, - rtc::ArrayView filtered_compressed_samples, - int luma_threshold, - int chroma_threshold) const; - private: struct ScalarConfig { float scale_factor; diff --git a/video/corruption_detection/frame_instrumentation_evaluation.cc b/video/corruption_detection/frame_instrumentation_evaluation.cc index f3367adf7b..500ac43dee 100644 --- a/video/corruption_detection/frame_instrumentation_evaluation.cc +++ b/video/corruption_detection/frame_instrumentation_evaluation.cc @@ -89,9 +89,9 @@ std::optional GetCorruptionScore(const FrameInstrumentationData& data, // classifier should we use? What input parameters should it have? CorruptionClassifier classifier(2.5); - return classifier.CalculateCorruptionProbablility( - data_samples, samples, data.luma_error_threshold, - data.chroma_error_threshold); + return classifier.CalculateCorruptionProbability(data_samples, samples, + data.luma_error_threshold, + data.chroma_error_threshold); } } // namespace webrtc