admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable RTCStatsIntegrationTest.GetsStatsWhileDestroyingPeerConnection

Browse Source 
The current implementation triggers vptr race condition due to the
test setup itself (see bug for the glorious details).
Disabling the test reduces TSAN noise and will help to detect more
critical defects.

Bug: webrtc:9847
Change-Id: I4912b00f1faad5f41ccaa4b55bc21b5215b816c9
Reviewed-on: https://webrtc-review.googlesource.com/c/110907
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25674}
This commit is contained in:
Yves Gerey 2018-11-14 18:00:14 +01:00 committed by Commit Bot
parent 6eb8a16dbf
commit b5bb513066
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pc/rtcstats_integrationtest.cc
View File

@ -806,7 +806,11 @@ TEST_F(RTCStatsIntegrationTest, GetStatsWithInvalidReceiverSelector) {
EXPECT_FALSE(report->size());
}
TEST_F(RTCStatsIntegrationTest, GetsStatsWhileDestroyingPeerConnections) {
// TODO(bugs.webrtc.org/9847) Remove this test altogether if a proper fix cannot
// be found. For now it is lying, as we cannot safely gets stats while
// destroying PeerConnection.
TEST_F(RTCStatsIntegrationTest,
DISABLED_GetsStatsWhileDestroyingPeerConnection) {
StartCall();
rtc::scoped_refptr<RTCStatsObtainer> stats_obtainer =