From b5bb5130661441327104443630d96da372a7cb02 Mon Sep 17 00:00:00 2001 From: Yves Gerey Date: Wed, 14 Nov 2018 18:00:14 +0100 Subject: [PATCH] Disable RTCStatsIntegrationTest.GetsStatsWhileDestroyingPeerConnection MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The current implementation triggers vptr race condition due to the test setup itself (see bug for the glorious details). Disabling the test reduces TSAN noise and will help to detect more critical defects. Bug: webrtc:9847 Change-Id: I4912b00f1faad5f41ccaa4b55bc21b5215b816c9 Reviewed-on: https://webrtc-review.googlesource.com/c/110907 Reviewed-by: Henrik Boström Commit-Queue: Yves Gerey Cr-Commit-Position: refs/heads/master@{#25674} --- pc/rtcstats_integrationtest.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pc/rtcstats_integrationtest.cc b/pc/rtcstats_integrationtest.cc index 3c07e38b5a..f9375f7415 100644 --- a/pc/rtcstats_integrationtest.cc +++ b/pc/rtcstats_integrationtest.cc @@ -806,7 +806,11 @@ TEST_F(RTCStatsIntegrationTest, GetStatsWithInvalidReceiverSelector) { EXPECT_FALSE(report->size()); } -TEST_F(RTCStatsIntegrationTest, GetsStatsWhileDestroyingPeerConnections) { +// TODO(bugs.webrtc.org/9847) Remove this test altogether if a proper fix cannot +// be found. For now it is lying, as we cannot safely gets stats while +// destroying PeerConnection. +TEST_F(RTCStatsIntegrationTest, + DISABLED_GetsStatsWhileDestroyingPeerConnection) { StartCall(); rtc::scoped_refptr stats_obtainer =