admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove obsolete IceProtocolType enum and SetIceProtocolType

Browse Source 
which only had a single member after the removal of
GICE around M42. The last downstream usage in Chromoting
was removed in
  https://chromium-review.googlesource.com/c/chromium/src/+/4385113

BUG=webrtc:4299

Change-Id: Id444967822cd19b0e514ba70739a8d45a7f78fae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299600
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#39945}
This commit is contained in:
Philipp Hancke 2023-03-31 09:35:27 +02:00 committed by WebRTC LUCI CQ
parent 83c8a3b885
commit b11caa366c
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
p2p/base/ice_transport_internal.h
View File

@ -228,12 +228,6 @@ enum class IceTransportState {
STATE_FAILED STATE_FAILED
}; };
// TODO(zhihuang): Remove this once it's no longer used in
// remoting/protocol/libjingle_transport_factory.cc
enum IceProtocolType {
ICEPROTO_RFC5245 // Standard RFC 5245 version of ICE.
};
// IceTransportInternal is an internal abstract class that does ICE. // IceTransportInternal is an internal abstract class that does ICE.
// Once the public interface is supported, // Once the public interface is supported,
// (https://www.w3.org/TR/webrtc/#rtcicetransport) // (https://www.w3.org/TR/webrtc/#rtcicetransport)
@ -256,10 +250,6 @@ class RTC_EXPORT IceTransportInternal : public rtc::PacketTransportInternal {
virtual void SetIceTiebreaker(uint64_t tiebreaker) = 0; virtual void SetIceTiebreaker(uint64_t tiebreaker) = 0;
// TODO(zhihuang): Remove this once it's no longer called in
// remoting/protocol/libjingle_transport_factory.cc
virtual void SetIceProtocolType(IceProtocolType type) {}
virtual void SetIceCredentials(absl::string_view ice_ufrag, virtual void SetIceCredentials(absl::string_view ice_ufrag,
absl::string_view ice_pwd); absl::string_view ice_pwd);