From b11caa366c5f0d9ff1dee023849b66b73f8efe04 Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Fri, 31 Mar 2023 09:35:27 +0200 Subject: [PATCH] Remove obsolete IceProtocolType enum and SetIceProtocolType which only had a single member after the removal of GICE around M42. The last downstream usage in Chromoting was removed in https://chromium-review.googlesource.com/c/chromium/src/+/4385113 BUG=webrtc:4299 Change-Id: Id444967822cd19b0e514ba70739a8d45a7f78fae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299600 Reviewed-by: Jonas Oreland Reviewed-by: Harald Alvestrand Commit-Queue: Philipp Hancke Cr-Commit-Position: refs/heads/main@{#39945} --- p2p/base/ice_transport_internal.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/p2p/base/ice_transport_internal.h b/p2p/base/ice_transport_internal.h index 3a93ab0484..55f12382aa 100644 --- a/p2p/base/ice_transport_internal.h +++ b/p2p/base/ice_transport_internal.h @@ -228,12 +228,6 @@ enum class IceTransportState { STATE_FAILED }; -// TODO(zhihuang): Remove this once it's no longer used in -// remoting/protocol/libjingle_transport_factory.cc -enum IceProtocolType { - ICEPROTO_RFC5245 // Standard RFC 5245 version of ICE. -}; - // IceTransportInternal is an internal abstract class that does ICE. // Once the public interface is supported, // (https://www.w3.org/TR/webrtc/#rtcicetransport) @@ -256,10 +250,6 @@ class RTC_EXPORT IceTransportInternal : public rtc::PacketTransportInternal { virtual void SetIceTiebreaker(uint64_t tiebreaker) = 0; - // TODO(zhihuang): Remove this once it's no longer called in - // remoting/protocol/libjingle_transport_factory.cc - virtual void SetIceProtocolType(IceProtocolType type) {} - virtual void SetIceCredentials(absl::string_view ice_ufrag, absl::string_view ice_pwd);