admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enabling clang::find_bad_constructs for desktop_capture.

Browse Source 
This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: I7ad7b03ae1b28fbf5712e671f361928c5e6d7a18
Reviewed-on: https://webrtc-review.googlesource.com/89384
Reviewed-by: Sergey Ulanov <sergeyu@google.com>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#24047}
This commit is contained in:
Mirko Bonadei 2018-07-18 15:58:09 +02:00 committed by Commit Bot
parent e12e68cc4e
commit a6bec58642
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/desktop_capture/BUILD.gn
View File

@ -113,10 +113,6 @@ if (rtc_include_tests) {
]
deps += [ ":desktop_capture_mock" ]
}
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
rtc_source_set("screen_drawer") {

2
modules/desktop_capture/screen_capturer_unittest.cc
View File

@ -74,7 +74,7 @@ class FakeSharedMemory : public SharedMemory {
public:
FakeSharedMemory(char* buffer, size_t size)
: SharedMemory(buffer, size, 0, kTestSharedMemoryId), buffer_(buffer) {}
virtual ~FakeSharedMemory() { delete[] buffer_; }
~FakeSharedMemory() override { delete[] buffer_; }
private:
char* buffer_;