From a6bec586421fcb0a553649707d047044a7fa8f33 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Wed, 18 Jul 2018 15:58:09 +0200 Subject: [PATCH] Enabling clang::find_bad_constructs for desktop_capture. This CL removes //build/config/clang:find_bad_constructs from the suppressed_configs list, which means that clang:find_bad_constructs is now enabled on these translation units. Bug: webrtc:9251, webrtc:163 Change-Id: I7ad7b03ae1b28fbf5712e671f361928c5e6d7a18 Reviewed-on: https://webrtc-review.googlesource.com/89384 Reviewed-by: Sergey Ulanov Reviewed-by: Sergey Ulanov Commit-Queue: Sergey Ulanov Cr-Commit-Position: refs/heads/master@{#24047} --- modules/desktop_capture/BUILD.gn | 4 ---- modules/desktop_capture/screen_capturer_unittest.cc | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/modules/desktop_capture/BUILD.gn b/modules/desktop_capture/BUILD.gn index 0860a96236..869b269ee8 100644 --- a/modules/desktop_capture/BUILD.gn +++ b/modules/desktop_capture/BUILD.gn @@ -113,10 +113,6 @@ if (rtc_include_tests) { ] deps += [ ":desktop_capture_mock" ] } - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } rtc_source_set("screen_drawer") { diff --git a/modules/desktop_capture/screen_capturer_unittest.cc b/modules/desktop_capture/screen_capturer_unittest.cc index 0264867aa4..90197d6169 100644 --- a/modules/desktop_capture/screen_capturer_unittest.cc +++ b/modules/desktop_capture/screen_capturer_unittest.cc @@ -74,7 +74,7 @@ class FakeSharedMemory : public SharedMemory { public: FakeSharedMemory(char* buffer, size_t size) : SharedMemory(buffer, size, 0, kTestSharedMemoryId), buffer_(buffer) {} - virtual ~FakeSharedMemory() { delete[] buffer_; } + ~FakeSharedMemory() override { delete[] buffer_; } private: char* buffer_;