admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update lower-level codereview.settings files.

Browse Source 
Every now and then we get CLs to codereview.webrtc.org
that are created from a Chromium checkout by editing
the code in third_party/webrtc or third_party/libjingle.

By editing these lower-level codereview.settings files,
we instead cause a crash during 'git cl upload', but the
contents of the file will also be printed, which can work
as an error message. The alternative would be to entirely
remove the files.

BUG=
R=andrew@webrtc.org, tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1389963002 .

Cr-Commit-Position: refs/heads/master@{#10191}
This commit is contained in:
Henrik Kjellander 2015-10-06 23:19:22 +02:00
parent a10492ff33
commit a38e31a054
3 changed files with 8 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
talk/codereview.settings
View File

@ -1,10 +1,4 @@
# This file is used by gcl to get repository specific information.
CODE_REVIEW_SERVER: codereview.webrtc.org
CC_LIST: webrtc-reviews@webrtc.org
VIEW_VC: https://chromium.googlesource.com/external/webrtc/+/
TRY_ON_UPLOAD: False
TRYSERVER_SVN_URL: svn://svn.chromium.org/chrome-try/try-webrtc
TRYSERVER_PROJECT: webrtc
TRYSERVER_ROOT: src/talk
PROJECT: webrtc
PENDING_REF_PREFIX: refs/pending/
Creating CLs from this location is not supported!
Please create a full WebRTC checkout using 'fetch webrtc'
or by cloning https://chromium.googlesource.com/external/webrtc

10
tools/codereview.settings
View File

@ -1,10 +0,0 @@
# This file is used by gcl to get repository specific information.
CODE_REVIEW_SERVER: codereview.webrtc.org
CC_LIST: webrtc-reviews@webrtc.org
VIEW_VC: https://chromium.googlesource.com/external/webrtc/+/
TRY_ON_UPLOAD: False
TRYSERVER_SVN_URL: svn://svn.chromium.org/chrome-try/try-webrtc
TRYSERVER_PROJECT: webrtc
TRYSERVER_ROOT: src/tools
PROJECT: webrtc
PENDING_REF_PREFIX: refs/pending/

14
webrtc/codereview.settings
View File

@ -1,10 +1,4 @@
# This file is used by gcl to get repository specific information.
CODE_REVIEW_SERVER: codereview.webrtc.org
CC_LIST: webrtc-reviews@webrtc.org
VIEW_VC: https://chromium.googlesource.com/external/webrtc/+/
TRY_ON_UPLOAD: False
TRYSERVER_SVN_URL: svn://svn.chromium.org/chrome-try/try-webrtc
TRYSERVER_PROJECT: webrtc
TRYSERVER_ROOT: src/webrtc
PROJECT: webrtc
PENDING_REF_PREFIX: refs/pending/
Creating CLs from this location is not supported!
Please create a full WebRTC checkout using 'fetch webrtc'
or by cloning https://chromium.googlesource.com/external/webrtc