From a38e31a054c1f3ac9b42931c58814993281744b2 Mon Sep 17 00:00:00 2001 From: Henrik Kjellander Date: Tue, 6 Oct 2015 23:19:22 +0200 Subject: [PATCH] Update lower-level codereview.settings files. Every now and then we get CLs to codereview.webrtc.org that are created from a Chromium checkout by editing the code in third_party/webrtc or third_party/libjingle. By editing these lower-level codereview.settings files, we instead cause a crash during 'git cl upload', but the contents of the file will also be printed, which can work as an error message. The alternative would be to entirely remove the files. BUG= R=andrew@webrtc.org, tommi@webrtc.org Review URL: https://codereview.webrtc.org/1389963002 . Cr-Commit-Position: refs/heads/master@{#10191} --- talk/codereview.settings | 14 ++++---------- tools/codereview.settings | 10 ---------- webrtc/codereview.settings | 14 ++++---------- 3 files changed, 8 insertions(+), 30 deletions(-) delete mode 100644 tools/codereview.settings diff --git a/talk/codereview.settings b/talk/codereview.settings index c138ebb7a7..97bee14549 100644 --- a/talk/codereview.settings +++ b/talk/codereview.settings @@ -1,10 +1,4 @@ -# This file is used by gcl to get repository specific information. -CODE_REVIEW_SERVER: codereview.webrtc.org -CC_LIST: webrtc-reviews@webrtc.org -VIEW_VC: https://chromium.googlesource.com/external/webrtc/+/ -TRY_ON_UPLOAD: False -TRYSERVER_SVN_URL: svn://svn.chromium.org/chrome-try/try-webrtc -TRYSERVER_PROJECT: webrtc -TRYSERVER_ROOT: src/talk -PROJECT: webrtc -PENDING_REF_PREFIX: refs/pending/ + +Creating CLs from this location is not supported! +Please create a full WebRTC checkout using 'fetch webrtc' +or by cloning https://chromium.googlesource.com/external/webrtc diff --git a/tools/codereview.settings b/tools/codereview.settings deleted file mode 100644 index 28913b3455..0000000000 --- a/tools/codereview.settings +++ /dev/null @@ -1,10 +0,0 @@ -# This file is used by gcl to get repository specific information. -CODE_REVIEW_SERVER: codereview.webrtc.org -CC_LIST: webrtc-reviews@webrtc.org -VIEW_VC: https://chromium.googlesource.com/external/webrtc/+/ -TRY_ON_UPLOAD: False -TRYSERVER_SVN_URL: svn://svn.chromium.org/chrome-try/try-webrtc -TRYSERVER_PROJECT: webrtc -TRYSERVER_ROOT: src/tools -PROJECT: webrtc -PENDING_REF_PREFIX: refs/pending/ diff --git a/webrtc/codereview.settings b/webrtc/codereview.settings index f32495343b..97bee14549 100644 --- a/webrtc/codereview.settings +++ b/webrtc/codereview.settings @@ -1,10 +1,4 @@ -# This file is used by gcl to get repository specific information. -CODE_REVIEW_SERVER: codereview.webrtc.org -CC_LIST: webrtc-reviews@webrtc.org -VIEW_VC: https://chromium.googlesource.com/external/webrtc/+/ -TRY_ON_UPLOAD: False -TRYSERVER_SVN_URL: svn://svn.chromium.org/chrome-try/try-webrtc -TRYSERVER_PROJECT: webrtc -TRYSERVER_ROOT: src/webrtc -PROJECT: webrtc -PENDING_REF_PREFIX: refs/pending/ + +Creating CLs from this location is not supported! +Please create a full WebRTC checkout using 'fetch webrtc' +or by cloning https://chromium.googlesource.com/external/webrtc