admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix usages of RTC_DCHECK to GTEST macros to ensure tests pass in release builds as well

Browse Source 
Using RTC_DCHECK for test validation is wrong to begin with (gets
compiled out in non-debug builds, which measn we may miss validations),
but becomes extra problematic when we include code with side-effects
inside the DCHECK, which results in release-build tests having a
different flow than intended

Bug: webrtc:15572
Change-Id: I89d5b55f903b9d93fe4a929548d1b9fcde8941be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323182
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41005}
This commit is contained in:
Guy Hershenbaum 2023-10-16 12:22:20 +03:00 committed by WebRTC LUCI CQ
parent 52ac8eccdf
commit a1714f3e92
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
modules/rtp_rtcp/source/rtcp_packet/transport_feedback_unittest.cc
View File

@ -60,11 +60,11 @@ MATCHER(IsValidFeedback, "") {
TransportFeedback Parse(rtc::ArrayView<const uint8_t> buffer) {
rtcp::CommonHeader header;
RTC_DCHECK(header.Parse(buffer.data(), buffer.size()));
RTC_DCHECK_EQ(header.type(), TransportFeedback::kPacketType);
RTC_DCHECK_EQ(header.fmt(), TransportFeedback::kFeedbackMessageType);
EXPECT_TRUE(header.Parse(buffer.data(), buffer.size()));
EXPECT_EQ(header.type(), TransportFeedback::kPacketType);
EXPECT_EQ(header.fmt(), TransportFeedback::kFeedbackMessageType);
TransportFeedback feedback;
RTC_DCHECK(feedback.Parse(header));
EXPECT_TRUE(feedback.Parse(header));
return feedback;
}
@ -89,7 +89,7 @@ class FeedbackTester {
temp_timestamps = GenerateReceiveTimestamps(received_seq);
received_ts = temp_timestamps;
}
RTC_DCHECK_EQ(received_seq.size(), received_ts.size());
ASSERT_EQ(received_seq.size(), received_ts.size());
expected_deltas_.clear();
feedback_.emplace(include_timestamps_);
@ -150,7 +150,7 @@ class FeedbackTester {
std::vector<Timestamp> GenerateReceiveTimestamps(
rtc::ArrayView<const uint16_t> seq_nums) {
RTC_DCHECK(!seq_nums.empty());
RTC_CHECK(!seq_nums.empty());
uint16_t last_seq = seq_nums[0];
Timestamp time = Timestamp::Zero();
std::vector<Timestamp> result;