admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Default enable NotUseAckedBitrateInAlr in loss basd bwe.

Browse Source 
Its finch/chrome experiment got approved in May.

Bug: webrtc:12707
Change-Id: I843dece38f32e844285b71575f6a04b63865f1b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323600
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40937}
This commit is contained in:
Diep Bui 2023-10-16 09:59:01 +00:00 committed by WebRTC LUCI CQ
parent 6113e199ff
commit 9f9b8e0b88
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc
View File

@ -422,7 +422,7 @@ absl::optional<LossBasedBweV2::Config> LossBasedBweV2::CreateConfig(
FieldTrialParameter<TimeDelta> probe_expiration("ProbeExpiration",
TimeDelta::Seconds(10));
FieldTrialParameter<bool> not_use_acked_rate_in_alr("NotUseAckedRateInAlr",
false);
true);
FieldTrialParameter<bool> use_in_start_phase("UseInStartPhase", false);
if (key_value_config) {
ParseFieldTrial({&enabled,

4
modules/congestion_controller/goog_cc/loss_based_bwe_v2_test.cc
View File

@ -1470,7 +1470,7 @@ TEST_P(LossBasedBweV2Test, NotBackOffToAckedRateInAlr) {
"Enabled:true,CandidateFactors:1.1|1.0|0.9,AckedRateCandidate:true,"
"ObservationWindowSize:2,"
"DelayBasedCandidate:true,InstantUpperBoundBwBalance:100kbps,"
"ObservationDurationLowerBound:200ms,NotUseAckedRateInAlr:true/");
"ObservationDurationLowerBound:200ms/");
LossBasedBweV2 loss_based_bandwidth_estimator(&key_value_config);
loss_based_bandwidth_estimator.SetMinMaxBitrate(
/*min_bitrate=*/DataRate::KilobitsPerSec(10),
@ -1505,7 +1505,7 @@ TEST_P(LossBasedBweV2Test, BackOffToAckedRateIfNotInAlr) {
"Enabled:true,CandidateFactors:1.1|1.0|0.9,AckedRateCandidate:true,"
"ObservationWindowSize:2,"
"DelayBasedCandidate:true,InstantUpperBoundBwBalance:100kbps,"
"ObservationDurationLowerBound:200ms,NotUseAckedRateInAlr:true/");
"ObservationDurationLowerBound:200ms/");
LossBasedBweV2 loss_based_bandwidth_estimator(&key_value_config);
loss_based_bandwidth_estimator.SetMinMaxBitrate(
/*min_bitrate=*/DataRate::KilobitsPerSec(10),