From 9f9b8e0b884d81e8b797e6405d40cd967e21d775 Mon Sep 17 00:00:00 2001 From: Diep Bui Date: Mon, 16 Oct 2023 09:59:01 +0000 Subject: [PATCH] Default enable NotUseAckedBitrateInAlr in loss basd bwe. Its finch/chrome experiment got approved in May. Bug: webrtc:12707 Change-Id: I843dece38f32e844285b71575f6a04b63865f1b8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323600 Commit-Queue: Per Kjellander Reviewed-by: Per Kjellander Commit-Queue: Diep Bui Cr-Commit-Position: refs/heads/main@{#40937} --- modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc | 2 +- .../congestion_controller/goog_cc/loss_based_bwe_v2_test.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc index b58f0f7520..18cec8263b 100644 --- a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc +++ b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc @@ -422,7 +422,7 @@ absl::optional LossBasedBweV2::CreateConfig( FieldTrialParameter probe_expiration("ProbeExpiration", TimeDelta::Seconds(10)); FieldTrialParameter not_use_acked_rate_in_alr("NotUseAckedRateInAlr", - false); + true); FieldTrialParameter use_in_start_phase("UseInStartPhase", false); if (key_value_config) { ParseFieldTrial({&enabled, diff --git a/modules/congestion_controller/goog_cc/loss_based_bwe_v2_test.cc b/modules/congestion_controller/goog_cc/loss_based_bwe_v2_test.cc index 780bd79a51..ca8fcf76d5 100644 --- a/modules/congestion_controller/goog_cc/loss_based_bwe_v2_test.cc +++ b/modules/congestion_controller/goog_cc/loss_based_bwe_v2_test.cc @@ -1470,7 +1470,7 @@ TEST_P(LossBasedBweV2Test, NotBackOffToAckedRateInAlr) { "Enabled:true,CandidateFactors:1.1|1.0|0.9,AckedRateCandidate:true," "ObservationWindowSize:2," "DelayBasedCandidate:true,InstantUpperBoundBwBalance:100kbps," - "ObservationDurationLowerBound:200ms,NotUseAckedRateInAlr:true/"); + "ObservationDurationLowerBound:200ms/"); LossBasedBweV2 loss_based_bandwidth_estimator(&key_value_config); loss_based_bandwidth_estimator.SetMinMaxBitrate( /*min_bitrate=*/DataRate::KilobitsPerSec(10), @@ -1505,7 +1505,7 @@ TEST_P(LossBasedBweV2Test, BackOffToAckedRateIfNotInAlr) { "Enabled:true,CandidateFactors:1.1|1.0|0.9,AckedRateCandidate:true," "ObservationWindowSize:2," "DelayBasedCandidate:true,InstantUpperBoundBwBalance:100kbps," - "ObservationDurationLowerBound:200ms,NotUseAckedRateInAlr:true/"); + "ObservationDurationLowerBound:200ms/"); LossBasedBweV2 loss_based_bandwidth_estimator(&key_value_config); loss_based_bandwidth_estimator.SetMinMaxBitrate( /*min_bitrate=*/DataRate::KilobitsPerSec(10),