Fix Chromium clang plugin warnings

NOTRY=true
BUG=webrtc:163

Review-Url: https://codereview.webrtc.org/2288133002
Cr-Commit-Position: refs/heads/master@{#13962}

webrtc/common_audio/sparse_fir_filter.cc

@@ -26,6 +26,8 @@ SparseFIRFilter::SparseFIRFilter(const float* nonzero_coeffs,
   RTC_CHECK_GE(sparsity, 1u);
 }
 
+SparseFIRFilter::~SparseFIRFilter() = default;
+
 void SparseFIRFilter::Filter(const float* in, size_t length, float* out) {
   // Convolves the input signal |in| with the filter kernel |nonzero_coeffs_|
   // taking into account the previous state.

webrtc/common_audio/sparse_fir_filter.h

@@ -33,6 +33,7 @@ class SparseFIRFilter final {
                   size_t num_nonzero_coeffs,
                   size_t sparsity,
                   size_t offset);
+  ~SparseFIRFilter();
 
   // Filters the |in| data supplied.
   // |out| must be previously allocated and it must be at least of |length|.

webrtc/modules/audio_processing/BUILD.gn

@@ -428,11 +428,6 @@ if (rtc_include_tests) {
     configs += [ "../..:common_config" ]
     public_configs = [ "../..:common_inherited_config" ]
 
-    if (is_clang) {
-      # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163).
-      configs -= [ "//build/config/clang:find_bad_constructs" ]
-    }
-
     deps = [
       "../../base:rtc_base_approved",
       "../../common_audio",
@@ -495,10 +490,6 @@ if (rtc_include_tests) {
         "//testing/gtest",
         "//third_party/gflags",
       ]
-      if (is_clang) {
-        # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163).
-        configs -= [ "//build/config/clang:find_bad_constructs" ]
-      }
     }
   }
 

webrtc/modules/audio_processing/splitting_filter.cc

@@ -31,6 +31,8 @@ SplittingFilter::SplittingFilter(size_t num_channels,
   }
 }
 
+SplittingFilter::~SplittingFilter() = default;
+
 void SplittingFilter::Analysis(const IFChannelBuffer* data,
                                IFChannelBuffer* bands) {
   RTC_DCHECK_EQ(num_bands_, bands->num_bands());

webrtc/modules/audio_processing/splitting_filter.h

@@ -46,6 +46,7 @@ struct TwoBandsStates {
 class SplittingFilter {
  public:
   SplittingFilter(size_t num_channels, size_t num_bands, size_t num_frames);
+  ~SplittingFilter();
 
   void Analysis(const IFChannelBuffer* data, IFChannelBuffer* bands);
   void Synthesis(const IFChannelBuffer* bands, IFChannelBuffer* data);

webrtc/modules/audio_processing/three_band_filter_bank.cc

@@ -131,6 +131,8 @@ ThreeBandFilterBank::ThreeBandFilterBank(size_t length)
   }
 }
 
+ThreeBandFilterBank::~ThreeBandFilterBank() = default;
+
 // The analysis can be separated in these steps:
 //   1. Serial to parallel downsampling by a factor of |kNumBands|.
 //   2. Filtering of |kSparsity| different delayed signals with polyphase

webrtc/modules/audio_processing/three_band_filter_bank.h

@@ -35,6 +35,7 @@ namespace webrtc {
 class ThreeBandFilterBank final {
  public:
   explicit ThreeBandFilterBank(size_t length);
+  ~ThreeBandFilterBank();
 
   // Splits |in| into 3 downsampled frequency bands in |out|.
   // |length| is the |in| length. Each of the 3 bands of |out| has to have a