diff --git a/webrtc/common_audio/sparse_fir_filter.cc b/webrtc/common_audio/sparse_fir_filter.cc index 5862b7cc6b..a79da07b2d 100644 --- a/webrtc/common_audio/sparse_fir_filter.cc +++ b/webrtc/common_audio/sparse_fir_filter.cc @@ -26,6 +26,8 @@ SparseFIRFilter::SparseFIRFilter(const float* nonzero_coeffs, RTC_CHECK_GE(sparsity, 1u); } +SparseFIRFilter::~SparseFIRFilter() = default; + void SparseFIRFilter::Filter(const float* in, size_t length, float* out) { // Convolves the input signal |in| with the filter kernel |nonzero_coeffs_| // taking into account the previous state. diff --git a/webrtc/common_audio/sparse_fir_filter.h b/webrtc/common_audio/sparse_fir_filter.h index 2ba5cf4600..2d406a0f19 100644 --- a/webrtc/common_audio/sparse_fir_filter.h +++ b/webrtc/common_audio/sparse_fir_filter.h @@ -33,6 +33,7 @@ class SparseFIRFilter final { size_t num_nonzero_coeffs, size_t sparsity, size_t offset); + ~SparseFIRFilter(); // Filters the |in| data supplied. // |out| must be previously allocated and it must be at least of |length|. diff --git a/webrtc/modules/audio_processing/BUILD.gn b/webrtc/modules/audio_processing/BUILD.gn index 9b3259f587..349a797ab1 100644 --- a/webrtc/modules/audio_processing/BUILD.gn +++ b/webrtc/modules/audio_processing/BUILD.gn @@ -428,11 +428,6 @@ if (rtc_include_tests) { configs += [ "../..:common_config" ] public_configs = [ "../..:common_inherited_config" ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). - configs -= [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "../../base:rtc_base_approved", "../../common_audio", @@ -495,10 +490,6 @@ if (rtc_include_tests) { "//testing/gtest", "//third_party/gflags", ] - if (is_clang) { - # Suppress warnings from the Chromium Clang plugins (bugs.webrtc.org/163). - configs -= [ "//build/config/clang:find_bad_constructs" ] - } } } diff --git a/webrtc/modules/audio_processing/splitting_filter.cc b/webrtc/modules/audio_processing/splitting_filter.cc index b6f642c09d..9f10935699 100644 --- a/webrtc/modules/audio_processing/splitting_filter.cc +++ b/webrtc/modules/audio_processing/splitting_filter.cc @@ -31,6 +31,8 @@ SplittingFilter::SplittingFilter(size_t num_channels, } } +SplittingFilter::~SplittingFilter() = default; + void SplittingFilter::Analysis(const IFChannelBuffer* data, IFChannelBuffer* bands) { RTC_DCHECK_EQ(num_bands_, bands->num_bands()); diff --git a/webrtc/modules/audio_processing/splitting_filter.h b/webrtc/modules/audio_processing/splitting_filter.h index 2828df3614..2d3750ae60 100644 --- a/webrtc/modules/audio_processing/splitting_filter.h +++ b/webrtc/modules/audio_processing/splitting_filter.h @@ -46,6 +46,7 @@ struct TwoBandsStates { class SplittingFilter { public: SplittingFilter(size_t num_channels, size_t num_bands, size_t num_frames); + ~SplittingFilter(); void Analysis(const IFChannelBuffer* data, IFChannelBuffer* bands); void Synthesis(const IFChannelBuffer* bands, IFChannelBuffer* data); diff --git a/webrtc/modules/audio_processing/three_band_filter_bank.cc b/webrtc/modules/audio_processing/three_band_filter_bank.cc index 3e87fe0f3f..61071bbff5 100644 --- a/webrtc/modules/audio_processing/three_band_filter_bank.cc +++ b/webrtc/modules/audio_processing/three_band_filter_bank.cc @@ -131,6 +131,8 @@ ThreeBandFilterBank::ThreeBandFilterBank(size_t length) } } +ThreeBandFilterBank::~ThreeBandFilterBank() = default; + // The analysis can be separated in these steps: // 1. Serial to parallel downsampling by a factor of |kNumBands|. // 2. Filtering of |kSparsity| different delayed signals with polyphase diff --git a/webrtc/modules/audio_processing/three_band_filter_bank.h b/webrtc/modules/audio_processing/three_band_filter_bank.h index eb9b99ee3b..24e7831d73 100644 --- a/webrtc/modules/audio_processing/three_band_filter_bank.h +++ b/webrtc/modules/audio_processing/three_band_filter_bank.h @@ -35,6 +35,7 @@ namespace webrtc { class ThreeBandFilterBank final { public: explicit ThreeBandFilterBank(size_t length); + ~ThreeBandFilterBank(); // Splits |in| into 3 downsampled frequency bands in |out|. // |length| is the |in| length. Each of the 3 bands of |out| has to have a