admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make RtpSenderInternal::CheckCodecParameters pure virtual

Browse Source 
Noted that the default implementation wasn't exercised by tests,
so worth removing.

Bug: None
Change-Id: I007ca54724ed27a8c37f34b9eaa188b0d46dd4e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/327300
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41143}
This commit is contained in:
Harald Alvestrand 2023-11-13 13:37:50 +00:00 committed by WebRTC LUCI CQ
parent 393cc11ca1
commit 9c91e48599
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pc/rtp_sender.h
View File

@ -86,9 +86,7 @@ class RtpSenderInternal : public RtpSenderInterface {
const RtpParameters& parameters) = 0;
// Additional checks that are specific to the current codec settings
virtual RTCError CheckCodecParameters(const RtpParameters& parameters) {
return RTCError::OK();
}
virtual RTCError CheckCodecParameters(const RtpParameters& parameters) = 0;
// Returns an ID that changes every time SetTrack() is called, but
// otherwise remains constant. Used to generate IDs for stats.