From 9c91e4859991e53afad51ab1727e3c9843ee3902 Mon Sep 17 00:00:00 2001 From: Harald Alvestrand Date: Mon, 13 Nov 2023 13:37:50 +0000 Subject: [PATCH] Make RtpSenderInternal::CheckCodecParameters pure virtual Noted that the default implementation wasn't exercised by tests, so worth removing. Bug: None Change-Id: I007ca54724ed27a8c37f34b9eaa188b0d46dd4e8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/327300 Commit-Queue: Harald Alvestrand Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#41143} --- pc/rtp_sender.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pc/rtp_sender.h b/pc/rtp_sender.h index 26adceb089..8925230636 100644 --- a/pc/rtp_sender.h +++ b/pc/rtp_sender.h @@ -86,9 +86,7 @@ class RtpSenderInternal : public RtpSenderInterface { const RtpParameters& parameters) = 0; // Additional checks that are specific to the current codec settings - virtual RTCError CheckCodecParameters(const RtpParameters& parameters) { - return RTCError::OK(); - } + virtual RTCError CheckCodecParameters(const RtpParameters& parameters) = 0; // Returns an ID that changes every time SetTrack() is called, but // otherwise remains constant. Used to generate IDs for stats.