admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make verbose log statements in sctp_data_channel DLOGs

Browse Source 
These log statements may have been useful when the initial code was
being written but now it's essentially dead code except for when
debugging while working on the code (and then, enabling the log
statements is simple).

Low-Coverage-Reason: CL modifies VERBOSE log lines that aren't currently covered.
Bug: none
Change-Id: Id9a45fe53574d39ff3feba08c596e0ac4ce294fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/297760
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39604}
This commit is contained in:
Tommi 2023-03-15 14:34:56 +01:00 committed by WebRTC LUCI CQ
parent 980c6bc09f
commit 934a88a460
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pc/sctp_data_channel.cc
View File

@ -454,7 +454,7 @@ void SctpDataChannel::OnDataReceived(DataMessageType type,
RTC_DCHECK(type == DataMessageType::kBinary || RTC_DCHECK(type == DataMessageType::kBinary ||
type == DataMessageType::kText); type == DataMessageType::kText);
RTC_LOG(LS_VERBOSE) << "DataChannel received DATA message, sid = " RTC_DLOG(LS_VERBOSE) << "DataChannel received DATA message, sid = "
<< id_.stream_id_int(); << id_.stream_id_int();
// We can send unordered as soon as we receive any DATA message since the // We can send unordered as soon as we receive any DATA message since the
// remote side must have received the OPEN (and old clients do not send // remote side must have received the OPEN (and old clients do not send
@ -655,7 +655,7 @@ bool SctpDataChannel::SendDataMessage(const DataBuffer& buffer,
// Send as ordered if it is still going through OPEN/ACK signaling. // Send as ordered if it is still going through OPEN/ACK signaling.
if (handshake_state_ != kHandshakeReady && !ordered_) { if (handshake_state_ != kHandshakeReady && !ordered_) {
send_params.ordered = true; send_params.ordered = true;
RTC_LOG(LS_VERBOSE) RTC_DLOG(LS_VERBOSE)
<< "Sending data as ordered for unordered DataChannel " << "Sending data as ordered for unordered DataChannel "
"because the OPEN_ACK message has not been received."; "because the OPEN_ACK message has not been received.";
} }
@ -746,7 +746,7 @@ bool SctpDataChannel::SendControlMessage(const rtc::CopyOnWriteBuffer& buffer) {
bool retval = controller_->SendData(id_.stream_id_int(), send_params, buffer, bool retval = controller_->SendData(id_.stream_id_int(), send_params, buffer,
&send_result); &send_result);
if (retval) { if (retval) {
RTC_LOG(LS_VERBOSE) << "Sent CONTROL message on channel " RTC_DLOG(LS_VERBOSE) << "Sent CONTROL message on channel "
<< id_.stream_id_int(); << id_.stream_id_int();
if (handshake_state_ == kHandshakeShouldSendAck) { if (handshake_state_ == kHandshakeShouldSendAck) {