From 934a88a460f320d54addd3830a132c8adb935b7c Mon Sep 17 00:00:00 2001 From: Tommi Date: Wed, 15 Mar 2023 14:34:56 +0100 Subject: [PATCH] Make verbose log statements in sctp_data_channel DLOGs These log statements may have been useful when the initial code was being written but now it's essentially dead code except for when debugging while working on the code (and then, enabling the log statements is simple). Low-Coverage-Reason: CL modifies VERBOSE log lines that aren't currently covered. Bug: none Change-Id: Id9a45fe53574d39ff3feba08c596e0ac4ce294fc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/297760 Commit-Queue: Tomas Gunnarsson Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#39604} --- pc/sctp_data_channel.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pc/sctp_data_channel.cc b/pc/sctp_data_channel.cc index 908e82567e..4f600ad1ea 100644 --- a/pc/sctp_data_channel.cc +++ b/pc/sctp_data_channel.cc @@ -454,8 +454,8 @@ void SctpDataChannel::OnDataReceived(DataMessageType type, RTC_DCHECK(type == DataMessageType::kBinary || type == DataMessageType::kText); - RTC_LOG(LS_VERBOSE) << "DataChannel received DATA message, sid = " - << id_.stream_id_int(); + RTC_DLOG(LS_VERBOSE) << "DataChannel received DATA message, sid = " + << id_.stream_id_int(); // We can send unordered as soon as we receive any DATA message since the // remote side must have received the OPEN (and old clients do not send // OPEN_ACK). @@ -655,7 +655,7 @@ bool SctpDataChannel::SendDataMessage(const DataBuffer& buffer, // Send as ordered if it is still going through OPEN/ACK signaling. if (handshake_state_ != kHandshakeReady && !ordered_) { send_params.ordered = true; - RTC_LOG(LS_VERBOSE) + RTC_DLOG(LS_VERBOSE) << "Sending data as ordered for unordered DataChannel " "because the OPEN_ACK message has not been received."; } @@ -746,8 +746,8 @@ bool SctpDataChannel::SendControlMessage(const rtc::CopyOnWriteBuffer& buffer) { bool retval = controller_->SendData(id_.stream_id_int(), send_params, buffer, &send_result); if (retval) { - RTC_LOG(LS_VERBOSE) << "Sent CONTROL message on channel " - << id_.stream_id_int(); + RTC_DLOG(LS_VERBOSE) << "Sent CONTROL message on channel " + << id_.stream_id_int(); if (handshake_state_ == kHandshakeShouldSendAck) { handshake_state_ = kHandshakeReady;