admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Comment unused variables in implemented functions 7\n

Browse Source 
Bug: webrtc:370878648
Change-Id: Id0a2c73b7055267de93d5301bd73e6212cf64794
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366261
Commit-Queue: Dor Hen <dorhen@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43315}
This commit is contained in:
Dor Hen 2024-10-27 14:49:27 +02:00 committed by WebRTC LUCI CQ
parent c4024d62a4
commit 90c67e7729
23 changed files with 84 additions and 78 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
api/environment/environment_unittest.cc
View File

@ -74,8 +74,8 @@ class FakeTaskQueueFactory : public TaskQueueFactory {
}
std::unique_ptr<TaskQueueBase, TaskQueueDeleter> CreateTaskQueue(
absl::string_view name,
Priority priority) const override {
absl::string_view /* name */,
Priority /* priority */) const override {
return nullptr;
}

2
api/jsep.cc
View File

@ -22,7 +22,7 @@ std::string IceCandidateInterface::server_url() const {
}
size_t SessionDescriptionInterface::RemoveCandidates(
const std::vector<cricket::Candidate>& candidates) {
const std::vector<cricket::Candidate>& /* candidates */) {
return 0;
}

3
api/metronome/metronome.h
View File

@ -36,7 +36,8 @@ class RTC_EXPORT Metronome {
// executed on the same sequence as they were requested on. There are no
// features for cancellation. When that's needed, use e.g. ScopedTaskSafety
// from the client.
virtual void RequestCallOnNextTick(absl::AnyInvocable<void() &&> callback) {}
virtual void RequestCallOnNextTick(
absl::AnyInvocable<void() &&> /* callback */) {}
// Returns the current tick period of the metronome.
virtual TimeDelta TickPeriod() const = 0;

4
api/neteq/neteq.h
View File

@ -194,7 +194,7 @@ class NetEq {
// Returns 0 on success, -1 on failure.
virtual int InsertPacket(const RTPHeader& rtp_header,
rtc::ArrayView<const uint8_t> payload,
Timestamp receive_time) {
Timestamp /* receive_time */) {
// TODO: webrtc:343501093 - Make this method pure virtual.
return InsertPacket(rtp_header, payload);
}
@ -300,7 +300,7 @@ class NetEq {
// such payload type was registered.
[[deprecated(
"Use GetCurrentDecoderFormat")]] virtual std::optional<DecoderFormat>
GetDecoderFormat(int payload_type) const {
GetDecoderFormat(int /* payload_type */) const {
return std::nullopt;
}

6
api/peer_connection_interface.h
View File

@ -830,7 +830,7 @@ class RTC_EXPORT PeerConnectionInterface : public webrtc::RefCountInterface {
// TODO(bugs.webrtc.org/9534): Rename to RemoveTrack once the other signature
// is removed; remove default implementation once upstream is updated.
virtual RTCError RemoveTrackOrError(
rtc::scoped_refptr<RtpSenderInterface> sender) {
rtc::scoped_refptr<RtpSenderInterface> /* sender */) {
RTC_CHECK_NOTREACHED();
return RTCError();
}
@ -971,8 +971,8 @@ class RTC_EXPORT PeerConnectionInterface : public webrtc::RefCountInterface {
// in SDP, so it should be done before CreateOffer is called, if the
// application plans to use data channels.
virtual RTCErrorOr<rtc::scoped_refptr<DataChannelInterface>>
CreateDataChannelOrError(const std::string& label,
const DataChannelInit* config) {
CreateDataChannelOrError(const std::string& /* label */,
const DataChannelInit* /* config */) {
return RTCError(RTCErrorType::INTERNAL_ERROR, "dummy function called");
}
// TODO(crbug.com/788659): Remove "virtual" below and default implementation

2
api/rtc_event_log/rtc_event_log_factory.h
View File

@ -27,7 +27,7 @@ class RTC_EXPORT RtcEventLogFactory : public RtcEventLogFactoryInterface {
RtcEventLogFactory() = default;
[[deprecated("Use default constructor")]] //
explicit RtcEventLogFactory(TaskQueueFactory* task_queue_factory) {}
explicit RtcEventLogFactory(TaskQueueFactory* /* task_queue_factory */) {}
~RtcEventLogFactory() override = default;

2
api/rtp_packet_sender.h
View File

@ -32,7 +32,7 @@ class RtpPacketSender {
// Clear any pending packets with the given SSRC from the queue.
// TODO(crbug.com/1395081): Make pure virtual when downstream code has been
// updated.
virtual void RemovePacketsForSsrc(uint32_t ssrc) {}
virtual void RemovePacketsForSsrc(uint32_t /* ssrc */) {}
};
} // namespace webrtc

4
api/rtp_receiver_interface.cc
View File

@ -36,7 +36,7 @@ std::vector<RtpSource> RtpReceiverInterface::GetSources() const {
}
void RtpReceiverInterface::SetFrameDecryptor(
rtc::scoped_refptr<FrameDecryptorInterface> frame_decryptor) {}
rtc::scoped_refptr<FrameDecryptorInterface> /* frame_decryptor */) {}
rtc::scoped_refptr<FrameDecryptorInterface>
RtpReceiverInterface::GetFrameDecryptor() const {
@ -49,6 +49,6 @@ RtpReceiverInterface::dtls_transport() const {
}
void RtpReceiverInterface::SetFrameTransformer(
rtc::scoped_refptr<FrameTransformerInterface> frame_transformer) {}
rtc::scoped_refptr<FrameTransformerInterface> /* frame_transformer */) {}
} // namespace webrtc

2
api/rtp_sender_interface.h
View File

@ -102,7 +102,7 @@ class RTC_EXPORT RtpSenderInterface : public webrtc::RefCountInterface,
// for this sender.
// Does not take ownership of observer.
// Must call SetObserver(nullptr) before the observer is destroyed.
virtual void SetObserver(RtpSenderObserverInterface* observer) {}
virtual void SetObserver(RtpSenderObserverInterface* /* observer */) {}
// Returns null for a video sender.
virtual rtc::scoped_refptr<DtmfSenderInterface> GetDtmfSender() const = 0;

2
api/rtp_transceiver_interface.cc
View File

@ -56,7 +56,7 @@ void RtpTransceiverInterface::SetDirection(
}
RTCError RtpTransceiverInterface::SetDirectionWithError(
RtpTransceiverDirection new_direction) {
RtpTransceiverDirection /* new_direction */) {
RTC_DCHECK_NOTREACHED() << "Default implementation called";
return RTCError::OK();
}

2
api/task_queue/default_task_queue_factory_gcd.cc
View File

@ -16,7 +16,7 @@
namespace webrtc {
std::unique_ptr<TaskQueueFactory> CreateDefaultTaskQueueFactory(
const FieldTrialsView* field_trials) {
const FieldTrialsView* /* field_trials */) {
return CreateTaskQueueGcdFactory();
}

8
api/test/fake_frame_decryptor.cc
View File

@ -25,9 +25,9 @@ FakeFrameDecryptor::FakeFrameDecryptor(uint8_t fake_key,
: fake_key_(fake_key), expected_postfix_byte_(expected_postfix_byte) {}
FakeFrameDecryptor::Result FakeFrameDecryptor::Decrypt(
cricket::MediaType media_type,
const std::vector<uint32_t>& csrcs,
rtc::ArrayView<const uint8_t> additional_data,
cricket::MediaType /* media_type */,
const std::vector<uint32_t>& /* csrcs */,
rtc::ArrayView<const uint8_t> /* additional_data */,
rtc::ArrayView<const uint8_t> encrypted_frame,
rtc::ArrayView<uint8_t> frame) {
if (fail_decryption_) {
@ -47,7 +47,7 @@ FakeFrameDecryptor::Result FakeFrameDecryptor::Decrypt(
}
size_t FakeFrameDecryptor::GetMaxPlaintextByteSize(
cricket::MediaType media_type,
cricket::MediaType /* media_type */,
size_t encrypted_frame_size) {
return encrypted_frame_size - 1;
}

9
api/test/fake_frame_encryptor.cc
View File

@ -22,9 +22,10 @@ FakeFrameEncryptor::FakeFrameEncryptor(uint8_t fake_key, uint8_t postfix_byte)
: fake_key_(fake_key), postfix_byte_(postfix_byte) {}
// FrameEncryptorInterface implementation
int FakeFrameEncryptor::Encrypt(cricket::MediaType media_type,
uint32_t ssrc,
rtc::ArrayView<const uint8_t> additional_data,
int FakeFrameEncryptor::Encrypt(
cricket::MediaType /* media_type */,
uint32_t /* ssrc */,
rtc::ArrayView<const uint8_t> /* additional_data */,
rtc::ArrayView<const uint8_t> frame,
rtc::ArrayView<uint8_t> encrypted_frame,
size_t* bytes_written) {
@ -43,7 +44,7 @@ int FakeFrameEncryptor::Encrypt(cricket::MediaType media_type,
}
size_t FakeFrameEncryptor::GetMaxCiphertextByteSize(
cricket::MediaType media_type,
cricket::MediaType /* media_type */,
size_t frame_size) {
return frame_size + 1;
}

2
api/test/peerconnection_quality_test_fixture_unittest.cc
View File

@ -85,7 +85,7 @@ struct TestVideoFrameWriter : public test::VideoFrameWriter {
const VideoResolution& resolution)
: file_name_prefix(file_name_prefix), resolution(resolution) {}
bool WriteFrame(const VideoFrame& frame) override { return true; }
bool WriteFrame(const VideoFrame& /* frame */) override { return true; }
void Close() override {}

2
api/test/simulated_network.h
View File

@ -124,7 +124,7 @@ class NetworkBehaviorInterface {
// DequeueDeliverablePackets call when network parameters (such as link
// capacity) changes.
virtual void RegisterDeliveryTimeChangedCallback(
absl::AnyInvocable<void()> callback) {}
absl::AnyInvocable<void()> /* callback */) {}
virtual ~NetworkBehaviorInterface() = default;
};

14
api/test/video/test_video_track_source.h
View File

@ -43,7 +43,7 @@ class TestVideoTrackSource : public Notifier<VideoTrackSourceInterface> {
bool is_screencast() const override { return false; }
std::optional<bool> needs_denoising() const override { return std::nullopt; }
bool GetStats(Stats* stats) override { return false; }
bool GetStats(Stats* /* stats */) override { return false; }
void AddOrUpdateSink(rtc::VideoSinkInterface<VideoFrame>* sink,
const rtc::VideoSinkWants& wants) override;
@ -52,9 +52,9 @@ class TestVideoTrackSource : public Notifier<VideoTrackSourceInterface> {
bool SupportsEncodedOutput() const override { return false; }
void GenerateKeyFrame() override {}
void AddEncodedSink(
rtc::VideoSinkInterface<RecordableEncodedFrame>* sink) override {}
rtc::VideoSinkInterface<RecordableEncodedFrame>* /* sink */) override {}
void RemoveEncodedSink(
rtc::VideoSinkInterface<RecordableEncodedFrame>* sink) override {}
rtc::VideoSinkInterface<RecordableEncodedFrame>* /* sink */) override {}
// Starts producing video.
virtual void Start() = 0;
@ -65,14 +65,14 @@ class TestVideoTrackSource : public Notifier<VideoTrackSourceInterface> {
virtual void SetScreencast(bool is_screencast) = 0;
// TODO(titovartem): make next 4 methods pure virtual.
virtual void SetEnableAdaptation(bool enable_adaptation) {}
virtual void SetEnableAdaptation(bool /* enable_adaptation */) {}
virtual int GetFrameWidth() const { return 0; }
virtual int GetFrameHeight() const { return 0; }
virtual void OnOutputFormatRequest(int width,
int height,
const std::optional<int>& max_fps) {}
virtual void OnOutputFormatRequest(int /* width */,
int /* height */,
const std::optional<int>& /* max_fps */) {}
// Returns stream label for this video source if present. Implementations
// may override this method to increase debugability and testability.

38
api/test/video_quality_analyzer_interface.h
View File

@ -87,9 +87,9 @@ class VideoQualityAnalyzerInterface
// calculations. Analyzer can perform simple calculations on the calling
// thread in each method, but should remember, that it is the same thread,
// that is used in video pipeline.
virtual void Start(std::string test_case_name,
rtc::ArrayView<const std::string> peer_names,
int max_threads_count) {}
virtual void Start(std::string /* test_case_name */,
rtc::ArrayView<const std::string> /* peer_names */,
int /* max_threads_count */) {}
// Will be called when frame was generated from the input stream.
// `peer_name` is name of the peer on which side frame was captured.
@ -99,34 +99,34 @@ class VideoQualityAnalyzerInterface
const VideoFrame& frame) = 0;
// Will be called before calling the encoder.
// `peer_name` is name of the peer on which side frame came to encoder.
virtual void OnFramePreEncode(absl::string_view peer_name,
const VideoFrame& frame) {}
virtual void OnFramePreEncode(absl::string_view /* peer_name */,
const VideoFrame& /* frame */) {}
// Will be called for each EncodedImage received from encoder. Single
// VideoFrame can produce multiple EncodedImages. Each encoded image will
// have id from VideoFrame.
// `peer_name` is name of the peer on which side frame was encoded.
virtual void OnFrameEncoded(absl::string_view peer_name,
uint16_t frame_id,
const EncodedImage& encoded_image,
const EncoderStats& stats,
bool discarded) {}
virtual void OnFrameEncoded(absl::string_view /* peer_name */,
uint16_t /* frame_id */,
const EncodedImage& /* encoded_image */,
const EncoderStats& /* stats */,
bool /* discarded */) {}
// Will be called for each frame dropped by encoder.
// `peer_name` is name of the peer on which side frame drop was detected.
virtual void OnFrameDropped(absl::string_view peer_name,
EncodedImageCallback::DropReason reason) {}
virtual void OnFrameDropped(absl::string_view /* peer_name */,
EncodedImageCallback::DropReason /* reason */) {}
// Will be called before calling the decoder.
// `peer_name` is name of the peer on which side frame was received.
virtual void OnFramePreDecode(absl::string_view peer_name,
uint16_t frame_id,
const EncodedImage& encoded_image) {}
virtual void OnFramePreDecode(absl::string_view /* peer_name */,
uint16_t /* frame_id */,
const EncodedImage& /* encoded_image */) {}
// Will be called after decoding the frame.
// `peer_name` is name of the peer on which side frame was decoded.
virtual void OnFrameDecoded(absl::string_view peer_name,
const VideoFrame& frame,
const DecoderStats& stats) {}
virtual void OnFrameDecoded(absl::string_view /* peer_name */,
const VideoFrame& /* frame */,
const DecoderStats& /* stats */) {}
// Will be called when frame will be obtained from PeerConnection stack.
// `peer_name` is name of the peer on which side frame was rendered.
virtual void OnFrameRendered(absl::string_view peer_name,
virtual void OnFrameRendered(absl::string_view /* peer_name */,
const VideoFrame& frame) {}
// Will be called if encoder return not WEBRTC_VIDEO_CODEC_OK.
// All available codes are listed in

14
api/transport/stun_unittest.cc
View File

@ -1610,13 +1610,14 @@ TEST_F(StunTest, EqualAttributes) {
auto copy = msg.Clone();
ASSERT_NE(nullptr, copy.get());
EXPECT_TRUE(copy->EqualAttributes(&msg, [](int type) { return true; }));
EXPECT_TRUE(copy->EqualAttributes(&msg, [](int /* type */) { return true; }));
{
auto attr = StunAttribute::CreateByteString(STUN_ATTR_NONCE);
attr->CopyBytes("keso");
msg.AddAttribute(std::move(attr));
EXPECT_FALSE(copy->EqualAttributes(&msg, [](int type) { return true; }));
EXPECT_FALSE(
copy->EqualAttributes(&msg, [](int /* type */) { return true; }));
EXPECT_TRUE(copy->EqualAttributes(
&msg, [](int type) { return type != STUN_ATTR_NONCE; }));
}
@ -1625,21 +1626,24 @@ TEST_F(StunTest, EqualAttributes) {
auto attr = StunAttribute::CreateByteString(STUN_ATTR_NONCE);
attr->CopyBytes("keso");
copy->AddAttribute(std::move(attr));
EXPECT_TRUE(copy->EqualAttributes(&msg, [](int type) { return true; }));
EXPECT_TRUE(
copy->EqualAttributes(&msg, [](int /* type */) { return true; }));
}
{
copy->RemoveAttribute(STUN_ATTR_NONCE);
auto attr = StunAttribute::CreateByteString(STUN_ATTR_NONCE);
attr->CopyBytes("kent");
copy->AddAttribute(std::move(attr));
EXPECT_FALSE(copy->EqualAttributes(&msg, [](int type) { return true; }));
EXPECT_FALSE(
copy->EqualAttributes(&msg, [](int /* type */) { return true; }));
EXPECT_TRUE(copy->EqualAttributes(
&msg, [](int type) { return type != STUN_ATTR_NONCE; }));
}
{
msg.RemoveAttribute(STUN_ATTR_NONCE);
EXPECT_FALSE(copy->EqualAttributes(&msg, [](int type) { return true; }));
EXPECT_FALSE(
copy->EqualAttributes(&msg, [](int /* type */) { return true; }));
EXPECT_TRUE(copy->EqualAttributes(
&msg, [](int type) { return type != STUN_ATTR_NONCE; }));
}

4
api/video_codecs/libaom_av1_encoder_factory.cc
View File

@ -269,8 +269,8 @@ ThreadTilesAndSuperblockSizeInfo GetThreadingTilesAndSuperblockSize(
}
bool ValidateEncodeParams(
const webrtc::VideoFrameBuffer& frame_buffer,
const VideoEncoderInterface::TemporalUnitSettings& tu_settings,
const webrtc::VideoFrameBuffer& /* frame_buffer */,
const VideoEncoderInterface::TemporalUnitSettings& /* tu_settings */,
const std::vector<VideoEncoderInterface::FrameEncodeSettings>&
frame_settings,
const std::array<std::optional<Resolution>, 8>& last_resolution_in_buffer,

2
api/video_codecs/libaom_av1_encoder_factory_test.cc
View File

@ -131,7 +131,7 @@ class FrameEncoderSettingsBuilder {
unread_.resize(size.bytes());
return unread_;
}
void EncodeComplete(const EncodeResult& encode_result) override {}
void EncodeComplete(const EncodeResult& /* encode_result */) override {}
private:
std::vector<uint8_t> unread_;

6
api/video_codecs/test/video_decoder_factory_template_tests.cc
View File

@ -43,7 +43,7 @@ struct FooDecoderTemplateAdapter {
static std::vector<SdpVideoFormat> SupportedFormats() { return {kFooSdp}; }
static std::unique_ptr<VideoDecoder> CreateDecoder(
const SdpVideoFormat& format) {
const SdpVideoFormat& /* format */) {
auto decoder = std::make_unique<testing::StrictMock<MockVideoDecoder>>();
EXPECT_CALL(*decoder, Destruct);
return decoder;
@ -56,8 +56,8 @@ struct BarDecoderTemplateAdapter {
}
static std::unique_ptr<VideoDecoder> CreateDecoder(
const Environment& env,
const SdpVideoFormat& format) {
const Environment& /* env */,
const SdpVideoFormat& /* format */) {
auto decoder = std::make_unique<testing::StrictMock<MockVideoDecoder>>();
EXPECT_CALL(*decoder, Destruct);
return decoder;

18
api/video_codecs/test/video_decoder_software_fallback_wrapper_unittest.cc
View File

@ -46,13 +46,13 @@ class VideoDecoderSoftwareFallbackWrapperTest : public ::testing::Test {
class CountingFakeDecoder : public VideoDecoder {
public:
bool Configure(const Settings& settings) override {
bool Configure(const Settings& /* settings */) override {
++configure_count_;
return configure_return_value_;
}
int32_t Decode(const EncodedImage& input_image,
int64_t render_time_ms) override {
int32_t Decode(const EncodedImage& /* input_image */,
int64_t /* render_time_ms */) override {
++decode_count_;
return decode_return_code_;
}
@ -183,15 +183,15 @@ TEST_F(VideoDecoderSoftwareFallbackWrapperTest, ForwardsReleaseCall) {
TEST_F(VideoDecoderSoftwareFallbackWrapperTest,
ForwardsRegisterDecodeCompleteCallback) {
class FakeDecodedImageCallback : public DecodedImageCallback {
int32_t Decoded(VideoFrame& decodedImage) override { return 0; }
int32_t Decoded(webrtc::VideoFrame& decodedImage,
int64_t decode_time_ms) override {
int32_t Decoded(VideoFrame& /* decodedImage */) override { return 0; }
int32_t Decoded(webrtc::VideoFrame& /* decodedImage */,
int64_t /* decode_time_ms */) override {
RTC_DCHECK_NOTREACHED();
return -1;
}
void Decoded(webrtc::VideoFrame& decodedImage,
std::optional<int32_t> decode_time_ms,
std::optional<uint8_t> qp) override {
void Decoded(webrtc::VideoFrame& /* decodedImage */,
std::optional<int32_t> /* decode_time_ms */,
std::optional<uint8_t> /* qp */) override {
RTC_DCHECK_NOTREACHED();
}
} callback;

6
api/video_codecs/test/video_encoder_factory_template_tests.cc
View File

@ -50,8 +50,8 @@ struct FooEncoderTemplateAdapter {
static std::vector<SdpVideoFormat> SupportedFormats() { return {kFooSdp}; }
static std::unique_ptr<VideoEncoder> CreateEncoder(
const Environment& env,
const SdpVideoFormat& format) {
const Environment& /* env */,
const SdpVideoFormat& /* format */) {
return std::make_unique<StrictMock<MockVideoEncoder>>();
}
@ -67,7 +67,7 @@ struct BarEncoderTemplateAdapter {
}
static std::unique_ptr<VideoEncoder> CreateEncoder(
const Environment& env,
const Environment& /* env */,
const SdpVideoFormat& format) {
return std::make_unique<StrictMock<MockVideoEncoder>>();
}