From 90c67e772991317dbeb31f7bd9608c59ff31ce53 Mon Sep 17 00:00:00 2001 From: Dor Hen Date: Sun, 27 Oct 2024 14:49:27 +0200 Subject: [PATCH] Comment unused variables in implemented functions 7\n Bug: webrtc:370878648 Change-Id: Id0a2c73b7055267de93d5301bd73e6212cf64794 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366261 Commit-Queue: Dor Hen Reviewed-by: Harald Alvestrand Reviewed-by: Danil Chapovalov Cr-Commit-Position: refs/heads/main@{#43315} --- api/environment/environment_unittest.cc | 4 +- api/jsep.cc | 2 +- api/metronome/metronome.h | 3 +- api/neteq/neteq.h | 4 +- api/peer_connection_interface.h | 6 +-- api/rtc_event_log/rtc_event_log_factory.h | 2 +- api/rtp_packet_sender.h | 2 +- api/rtp_receiver_interface.cc | 4 +- api/rtp_sender_interface.h | 2 +- api/rtp_transceiver_interface.cc | 2 +- .../default_task_queue_factory_gcd.cc | 2 +- api/test/fake_frame_decryptor.cc | 8 ++-- api/test/fake_frame_encryptor.cc | 15 ++++---- ...onnection_quality_test_fixture_unittest.cc | 2 +- api/test/simulated_network.h | 2 +- api/test/video/test_video_track_source.h | 14 +++---- api/test/video_quality_analyzer_interface.h | 38 +++++++++---------- api/transport/stun_unittest.cc | 14 ++++--- .../libaom_av1_encoder_factory.cc | 4 +- .../libaom_av1_encoder_factory_test.cc | 2 +- .../video_decoder_factory_template_tests.cc | 6 +-- ...oder_software_fallback_wrapper_unittest.cc | 18 ++++----- .../video_encoder_factory_template_tests.cc | 6 +-- 23 files changed, 84 insertions(+), 78 deletions(-) diff --git a/api/environment/environment_unittest.cc b/api/environment/environment_unittest.cc index 74787bf7f9..12dd40d70a 100644 --- a/api/environment/environment_unittest.cc +++ b/api/environment/environment_unittest.cc @@ -74,8 +74,8 @@ class FakeTaskQueueFactory : public TaskQueueFactory { } std::unique_ptr CreateTaskQueue( - absl::string_view name, - Priority priority) const override { + absl::string_view /* name */, + Priority /* priority */) const override { return nullptr; } diff --git a/api/jsep.cc b/api/jsep.cc index 894ef58f40..05e07731f8 100644 --- a/api/jsep.cc +++ b/api/jsep.cc @@ -22,7 +22,7 @@ std::string IceCandidateInterface::server_url() const { } size_t SessionDescriptionInterface::RemoveCandidates( - const std::vector& candidates) { + const std::vector& /* candidates */) { return 0; } diff --git a/api/metronome/metronome.h b/api/metronome/metronome.h index 4d50a3ecd0..fb079762c2 100644 --- a/api/metronome/metronome.h +++ b/api/metronome/metronome.h @@ -36,7 +36,8 @@ class RTC_EXPORT Metronome { // executed on the same sequence as they were requested on. There are no // features for cancellation. When that's needed, use e.g. ScopedTaskSafety // from the client. - virtual void RequestCallOnNextTick(absl::AnyInvocable callback) {} + virtual void RequestCallOnNextTick( + absl::AnyInvocable /* callback */) {} // Returns the current tick period of the metronome. virtual TimeDelta TickPeriod() const = 0; diff --git a/api/neteq/neteq.h b/api/neteq/neteq.h index faa56245e1..f8062de8bd 100644 --- a/api/neteq/neteq.h +++ b/api/neteq/neteq.h @@ -194,7 +194,7 @@ class NetEq { // Returns 0 on success, -1 on failure. virtual int InsertPacket(const RTPHeader& rtp_header, rtc::ArrayView payload, - Timestamp receive_time) { + Timestamp /* receive_time */) { // TODO: webrtc:343501093 - Make this method pure virtual. return InsertPacket(rtp_header, payload); } @@ -300,7 +300,7 @@ class NetEq { // such payload type was registered. [[deprecated( "Use GetCurrentDecoderFormat")]] virtual std::optional - GetDecoderFormat(int payload_type) const { + GetDecoderFormat(int /* payload_type */) const { return std::nullopt; } diff --git a/api/peer_connection_interface.h b/api/peer_connection_interface.h index 8082a5241d..4349d6bb3c 100644 --- a/api/peer_connection_interface.h +++ b/api/peer_connection_interface.h @@ -830,7 +830,7 @@ class RTC_EXPORT PeerConnectionInterface : public webrtc::RefCountInterface { // TODO(bugs.webrtc.org/9534): Rename to RemoveTrack once the other signature // is removed; remove default implementation once upstream is updated. virtual RTCError RemoveTrackOrError( - rtc::scoped_refptr sender) { + rtc::scoped_refptr /* sender */) { RTC_CHECK_NOTREACHED(); return RTCError(); } @@ -971,8 +971,8 @@ class RTC_EXPORT PeerConnectionInterface : public webrtc::RefCountInterface { // in SDP, so it should be done before CreateOffer is called, if the // application plans to use data channels. virtual RTCErrorOr> - CreateDataChannelOrError(const std::string& label, - const DataChannelInit* config) { + CreateDataChannelOrError(const std::string& /* label */, + const DataChannelInit* /* config */) { return RTCError(RTCErrorType::INTERNAL_ERROR, "dummy function called"); } // TODO(crbug.com/788659): Remove "virtual" below and default implementation diff --git a/api/rtc_event_log/rtc_event_log_factory.h b/api/rtc_event_log/rtc_event_log_factory.h index 1deb0612bf..df07e2db00 100644 --- a/api/rtc_event_log/rtc_event_log_factory.h +++ b/api/rtc_event_log/rtc_event_log_factory.h @@ -27,7 +27,7 @@ class RTC_EXPORT RtcEventLogFactory : public RtcEventLogFactoryInterface { RtcEventLogFactory() = default; [[deprecated("Use default constructor")]] // - explicit RtcEventLogFactory(TaskQueueFactory* task_queue_factory) {} + explicit RtcEventLogFactory(TaskQueueFactory* /* task_queue_factory */) {} ~RtcEventLogFactory() override = default; diff --git a/api/rtp_packet_sender.h b/api/rtp_packet_sender.h index 13cb37f867..92220a1fbf 100644 --- a/api/rtp_packet_sender.h +++ b/api/rtp_packet_sender.h @@ -32,7 +32,7 @@ class RtpPacketSender { // Clear any pending packets with the given SSRC from the queue. // TODO(crbug.com/1395081): Make pure virtual when downstream code has been // updated. - virtual void RemovePacketsForSsrc(uint32_t ssrc) {} + virtual void RemovePacketsForSsrc(uint32_t /* ssrc */) {} }; } // namespace webrtc diff --git a/api/rtp_receiver_interface.cc b/api/rtp_receiver_interface.cc index 4868f2c3aa..436b0f1aaa 100644 --- a/api/rtp_receiver_interface.cc +++ b/api/rtp_receiver_interface.cc @@ -36,7 +36,7 @@ std::vector RtpReceiverInterface::GetSources() const { } void RtpReceiverInterface::SetFrameDecryptor( - rtc::scoped_refptr frame_decryptor) {} + rtc::scoped_refptr /* frame_decryptor */) {} rtc::scoped_refptr RtpReceiverInterface::GetFrameDecryptor() const { @@ -49,6 +49,6 @@ RtpReceiverInterface::dtls_transport() const { } void RtpReceiverInterface::SetFrameTransformer( - rtc::scoped_refptr frame_transformer) {} + rtc::scoped_refptr /* frame_transformer */) {} } // namespace webrtc diff --git a/api/rtp_sender_interface.h b/api/rtp_sender_interface.h index 36b261044b..91d7b3c561 100644 --- a/api/rtp_sender_interface.h +++ b/api/rtp_sender_interface.h @@ -102,7 +102,7 @@ class RTC_EXPORT RtpSenderInterface : public webrtc::RefCountInterface, // for this sender. // Does not take ownership of observer. // Must call SetObserver(nullptr) before the observer is destroyed. - virtual void SetObserver(RtpSenderObserverInterface* observer) {} + virtual void SetObserver(RtpSenderObserverInterface* /* observer */) {} // Returns null for a video sender. virtual rtc::scoped_refptr GetDtmfSender() const = 0; diff --git a/api/rtp_transceiver_interface.cc b/api/rtp_transceiver_interface.cc index dea2e9c1f3..1a9429b8d8 100644 --- a/api/rtp_transceiver_interface.cc +++ b/api/rtp_transceiver_interface.cc @@ -56,7 +56,7 @@ void RtpTransceiverInterface::SetDirection( } RTCError RtpTransceiverInterface::SetDirectionWithError( - RtpTransceiverDirection new_direction) { + RtpTransceiverDirection /* new_direction */) { RTC_DCHECK_NOTREACHED() << "Default implementation called"; return RTCError::OK(); } diff --git a/api/task_queue/default_task_queue_factory_gcd.cc b/api/task_queue/default_task_queue_factory_gcd.cc index 391f09b393..fb293b3ced 100644 --- a/api/task_queue/default_task_queue_factory_gcd.cc +++ b/api/task_queue/default_task_queue_factory_gcd.cc @@ -16,7 +16,7 @@ namespace webrtc { std::unique_ptr CreateDefaultTaskQueueFactory( - const FieldTrialsView* field_trials) { + const FieldTrialsView* /* field_trials */) { return CreateTaskQueueGcdFactory(); } diff --git a/api/test/fake_frame_decryptor.cc b/api/test/fake_frame_decryptor.cc index c82db2c542..e5bcc57960 100644 --- a/api/test/fake_frame_decryptor.cc +++ b/api/test/fake_frame_decryptor.cc @@ -25,9 +25,9 @@ FakeFrameDecryptor::FakeFrameDecryptor(uint8_t fake_key, : fake_key_(fake_key), expected_postfix_byte_(expected_postfix_byte) {} FakeFrameDecryptor::Result FakeFrameDecryptor::Decrypt( - cricket::MediaType media_type, - const std::vector& csrcs, - rtc::ArrayView additional_data, + cricket::MediaType /* media_type */, + const std::vector& /* csrcs */, + rtc::ArrayView /* additional_data */, rtc::ArrayView encrypted_frame, rtc::ArrayView frame) { if (fail_decryption_) { @@ -47,7 +47,7 @@ FakeFrameDecryptor::Result FakeFrameDecryptor::Decrypt( } size_t FakeFrameDecryptor::GetMaxPlaintextByteSize( - cricket::MediaType media_type, + cricket::MediaType /* media_type */, size_t encrypted_frame_size) { return encrypted_frame_size - 1; } diff --git a/api/test/fake_frame_encryptor.cc b/api/test/fake_frame_encryptor.cc index 2911e84d26..ec3159634c 100644 --- a/api/test/fake_frame_encryptor.cc +++ b/api/test/fake_frame_encryptor.cc @@ -22,12 +22,13 @@ FakeFrameEncryptor::FakeFrameEncryptor(uint8_t fake_key, uint8_t postfix_byte) : fake_key_(fake_key), postfix_byte_(postfix_byte) {} // FrameEncryptorInterface implementation -int FakeFrameEncryptor::Encrypt(cricket::MediaType media_type, - uint32_t ssrc, - rtc::ArrayView additional_data, - rtc::ArrayView frame, - rtc::ArrayView encrypted_frame, - size_t* bytes_written) { +int FakeFrameEncryptor::Encrypt( + cricket::MediaType /* media_type */, + uint32_t /* ssrc */, + rtc::ArrayView /* additional_data */, + rtc::ArrayView frame, + rtc::ArrayView encrypted_frame, + size_t* bytes_written) { if (fail_encryption_) { return static_cast(FakeEncryptionStatus::FORCED_FAILURE); } @@ -43,7 +44,7 @@ int FakeFrameEncryptor::Encrypt(cricket::MediaType media_type, } size_t FakeFrameEncryptor::GetMaxCiphertextByteSize( - cricket::MediaType media_type, + cricket::MediaType /* media_type */, size_t frame_size) { return frame_size + 1; } diff --git a/api/test/peerconnection_quality_test_fixture_unittest.cc b/api/test/peerconnection_quality_test_fixture_unittest.cc index 970fbf648c..ed0dc55bb1 100644 --- a/api/test/peerconnection_quality_test_fixture_unittest.cc +++ b/api/test/peerconnection_quality_test_fixture_unittest.cc @@ -85,7 +85,7 @@ struct TestVideoFrameWriter : public test::VideoFrameWriter { const VideoResolution& resolution) : file_name_prefix(file_name_prefix), resolution(resolution) {} - bool WriteFrame(const VideoFrame& frame) override { return true; } + bool WriteFrame(const VideoFrame& /* frame */) override { return true; } void Close() override {} diff --git a/api/test/simulated_network.h b/api/test/simulated_network.h index 245b8f062a..7b572a7de6 100644 --- a/api/test/simulated_network.h +++ b/api/test/simulated_network.h @@ -124,7 +124,7 @@ class NetworkBehaviorInterface { // DequeueDeliverablePackets call when network parameters (such as link // capacity) changes. virtual void RegisterDeliveryTimeChangedCallback( - absl::AnyInvocable callback) {} + absl::AnyInvocable /* callback */) {} virtual ~NetworkBehaviorInterface() = default; }; diff --git a/api/test/video/test_video_track_source.h b/api/test/video/test_video_track_source.h index 95daccfa36..fb0025b16e 100644 --- a/api/test/video/test_video_track_source.h +++ b/api/test/video/test_video_track_source.h @@ -43,7 +43,7 @@ class TestVideoTrackSource : public Notifier { bool is_screencast() const override { return false; } std::optional needs_denoising() const override { return std::nullopt; } - bool GetStats(Stats* stats) override { return false; } + bool GetStats(Stats* /* stats */) override { return false; } void AddOrUpdateSink(rtc::VideoSinkInterface* sink, const rtc::VideoSinkWants& wants) override; @@ -52,9 +52,9 @@ class TestVideoTrackSource : public Notifier { bool SupportsEncodedOutput() const override { return false; } void GenerateKeyFrame() override {} void AddEncodedSink( - rtc::VideoSinkInterface* sink) override {} + rtc::VideoSinkInterface* /* sink */) override {} void RemoveEncodedSink( - rtc::VideoSinkInterface* sink) override {} + rtc::VideoSinkInterface* /* sink */) override {} // Starts producing video. virtual void Start() = 0; @@ -65,14 +65,14 @@ class TestVideoTrackSource : public Notifier { virtual void SetScreencast(bool is_screencast) = 0; // TODO(titovartem): make next 4 methods pure virtual. - virtual void SetEnableAdaptation(bool enable_adaptation) {} + virtual void SetEnableAdaptation(bool /* enable_adaptation */) {} virtual int GetFrameWidth() const { return 0; } virtual int GetFrameHeight() const { return 0; } - virtual void OnOutputFormatRequest(int width, - int height, - const std::optional& max_fps) {} + virtual void OnOutputFormatRequest(int /* width */, + int /* height */, + const std::optional& /* max_fps */) {} // Returns stream label for this video source if present. Implementations // may override this method to increase debugability and testability. diff --git a/api/test/video_quality_analyzer_interface.h b/api/test/video_quality_analyzer_interface.h index 8c9498fc72..c9b7851ab0 100644 --- a/api/test/video_quality_analyzer_interface.h +++ b/api/test/video_quality_analyzer_interface.h @@ -87,9 +87,9 @@ class VideoQualityAnalyzerInterface // calculations. Analyzer can perform simple calculations on the calling // thread in each method, but should remember, that it is the same thread, // that is used in video pipeline. - virtual void Start(std::string test_case_name, - rtc::ArrayView peer_names, - int max_threads_count) {} + virtual void Start(std::string /* test_case_name */, + rtc::ArrayView /* peer_names */, + int /* max_threads_count */) {} // Will be called when frame was generated from the input stream. // `peer_name` is name of the peer on which side frame was captured. @@ -99,34 +99,34 @@ class VideoQualityAnalyzerInterface const VideoFrame& frame) = 0; // Will be called before calling the encoder. // `peer_name` is name of the peer on which side frame came to encoder. - virtual void OnFramePreEncode(absl::string_view peer_name, - const VideoFrame& frame) {} + virtual void OnFramePreEncode(absl::string_view /* peer_name */, + const VideoFrame& /* frame */) {} // Will be called for each EncodedImage received from encoder. Single // VideoFrame can produce multiple EncodedImages. Each encoded image will // have id from VideoFrame. // `peer_name` is name of the peer on which side frame was encoded. - virtual void OnFrameEncoded(absl::string_view peer_name, - uint16_t frame_id, - const EncodedImage& encoded_image, - const EncoderStats& stats, - bool discarded) {} + virtual void OnFrameEncoded(absl::string_view /* peer_name */, + uint16_t /* frame_id */, + const EncodedImage& /* encoded_image */, + const EncoderStats& /* stats */, + bool /* discarded */) {} // Will be called for each frame dropped by encoder. // `peer_name` is name of the peer on which side frame drop was detected. - virtual void OnFrameDropped(absl::string_view peer_name, - EncodedImageCallback::DropReason reason) {} + virtual void OnFrameDropped(absl::string_view /* peer_name */, + EncodedImageCallback::DropReason /* reason */) {} // Will be called before calling the decoder. // `peer_name` is name of the peer on which side frame was received. - virtual void OnFramePreDecode(absl::string_view peer_name, - uint16_t frame_id, - const EncodedImage& encoded_image) {} + virtual void OnFramePreDecode(absl::string_view /* peer_name */, + uint16_t /* frame_id */, + const EncodedImage& /* encoded_image */) {} // Will be called after decoding the frame. // `peer_name` is name of the peer on which side frame was decoded. - virtual void OnFrameDecoded(absl::string_view peer_name, - const VideoFrame& frame, - const DecoderStats& stats) {} + virtual void OnFrameDecoded(absl::string_view /* peer_name */, + const VideoFrame& /* frame */, + const DecoderStats& /* stats */) {} // Will be called when frame will be obtained from PeerConnection stack. // `peer_name` is name of the peer on which side frame was rendered. - virtual void OnFrameRendered(absl::string_view peer_name, + virtual void OnFrameRendered(absl::string_view /* peer_name */, const VideoFrame& frame) {} // Will be called if encoder return not WEBRTC_VIDEO_CODEC_OK. // All available codes are listed in diff --git a/api/transport/stun_unittest.cc b/api/transport/stun_unittest.cc index 9d0352bb80..000562f9cf 100644 --- a/api/transport/stun_unittest.cc +++ b/api/transport/stun_unittest.cc @@ -1610,13 +1610,14 @@ TEST_F(StunTest, EqualAttributes) { auto copy = msg.Clone(); ASSERT_NE(nullptr, copy.get()); - EXPECT_TRUE(copy->EqualAttributes(&msg, [](int type) { return true; })); + EXPECT_TRUE(copy->EqualAttributes(&msg, [](int /* type */) { return true; })); { auto attr = StunAttribute::CreateByteString(STUN_ATTR_NONCE); attr->CopyBytes("keso"); msg.AddAttribute(std::move(attr)); - EXPECT_FALSE(copy->EqualAttributes(&msg, [](int type) { return true; })); + EXPECT_FALSE( + copy->EqualAttributes(&msg, [](int /* type */) { return true; })); EXPECT_TRUE(copy->EqualAttributes( &msg, [](int type) { return type != STUN_ATTR_NONCE; })); } @@ -1625,21 +1626,24 @@ TEST_F(StunTest, EqualAttributes) { auto attr = StunAttribute::CreateByteString(STUN_ATTR_NONCE); attr->CopyBytes("keso"); copy->AddAttribute(std::move(attr)); - EXPECT_TRUE(copy->EqualAttributes(&msg, [](int type) { return true; })); + EXPECT_TRUE( + copy->EqualAttributes(&msg, [](int /* type */) { return true; })); } { copy->RemoveAttribute(STUN_ATTR_NONCE); auto attr = StunAttribute::CreateByteString(STUN_ATTR_NONCE); attr->CopyBytes("kent"); copy->AddAttribute(std::move(attr)); - EXPECT_FALSE(copy->EqualAttributes(&msg, [](int type) { return true; })); + EXPECT_FALSE( + copy->EqualAttributes(&msg, [](int /* type */) { return true; })); EXPECT_TRUE(copy->EqualAttributes( &msg, [](int type) { return type != STUN_ATTR_NONCE; })); } { msg.RemoveAttribute(STUN_ATTR_NONCE); - EXPECT_FALSE(copy->EqualAttributes(&msg, [](int type) { return true; })); + EXPECT_FALSE( + copy->EqualAttributes(&msg, [](int /* type */) { return true; })); EXPECT_TRUE(copy->EqualAttributes( &msg, [](int type) { return type != STUN_ATTR_NONCE; })); } diff --git a/api/video_codecs/libaom_av1_encoder_factory.cc b/api/video_codecs/libaom_av1_encoder_factory.cc index 968120e9df..c1b5a9292b 100644 --- a/api/video_codecs/libaom_av1_encoder_factory.cc +++ b/api/video_codecs/libaom_av1_encoder_factory.cc @@ -269,8 +269,8 @@ ThreadTilesAndSuperblockSizeInfo GetThreadingTilesAndSuperblockSize( } bool ValidateEncodeParams( - const webrtc::VideoFrameBuffer& frame_buffer, - const VideoEncoderInterface::TemporalUnitSettings& tu_settings, + const webrtc::VideoFrameBuffer& /* frame_buffer */, + const VideoEncoderInterface::TemporalUnitSettings& /* tu_settings */, const std::vector& frame_settings, const std::array, 8>& last_resolution_in_buffer, diff --git a/api/video_codecs/libaom_av1_encoder_factory_test.cc b/api/video_codecs/libaom_av1_encoder_factory_test.cc index 0d87a8c57b..a704b289ad 100644 --- a/api/video_codecs/libaom_av1_encoder_factory_test.cc +++ b/api/video_codecs/libaom_av1_encoder_factory_test.cc @@ -131,7 +131,7 @@ class FrameEncoderSettingsBuilder { unread_.resize(size.bytes()); return unread_; } - void EncodeComplete(const EncodeResult& encode_result) override {} + void EncodeComplete(const EncodeResult& /* encode_result */) override {} private: std::vector unread_; diff --git a/api/video_codecs/test/video_decoder_factory_template_tests.cc b/api/video_codecs/test/video_decoder_factory_template_tests.cc index d2a631f019..8cae8be0bf 100644 --- a/api/video_codecs/test/video_decoder_factory_template_tests.cc +++ b/api/video_codecs/test/video_decoder_factory_template_tests.cc @@ -43,7 +43,7 @@ struct FooDecoderTemplateAdapter { static std::vector SupportedFormats() { return {kFooSdp}; } static std::unique_ptr CreateDecoder( - const SdpVideoFormat& format) { + const SdpVideoFormat& /* format */) { auto decoder = std::make_unique>(); EXPECT_CALL(*decoder, Destruct); return decoder; @@ -56,8 +56,8 @@ struct BarDecoderTemplateAdapter { } static std::unique_ptr CreateDecoder( - const Environment& env, - const SdpVideoFormat& format) { + const Environment& /* env */, + const SdpVideoFormat& /* format */) { auto decoder = std::make_unique>(); EXPECT_CALL(*decoder, Destruct); return decoder; diff --git a/api/video_codecs/test/video_decoder_software_fallback_wrapper_unittest.cc b/api/video_codecs/test/video_decoder_software_fallback_wrapper_unittest.cc index 873648450c..d452884c11 100644 --- a/api/video_codecs/test/video_decoder_software_fallback_wrapper_unittest.cc +++ b/api/video_codecs/test/video_decoder_software_fallback_wrapper_unittest.cc @@ -46,13 +46,13 @@ class VideoDecoderSoftwareFallbackWrapperTest : public ::testing::Test { class CountingFakeDecoder : public VideoDecoder { public: - bool Configure(const Settings& settings) override { + bool Configure(const Settings& /* settings */) override { ++configure_count_; return configure_return_value_; } - int32_t Decode(const EncodedImage& input_image, - int64_t render_time_ms) override { + int32_t Decode(const EncodedImage& /* input_image */, + int64_t /* render_time_ms */) override { ++decode_count_; return decode_return_code_; } @@ -183,15 +183,15 @@ TEST_F(VideoDecoderSoftwareFallbackWrapperTest, ForwardsReleaseCall) { TEST_F(VideoDecoderSoftwareFallbackWrapperTest, ForwardsRegisterDecodeCompleteCallback) { class FakeDecodedImageCallback : public DecodedImageCallback { - int32_t Decoded(VideoFrame& decodedImage) override { return 0; } - int32_t Decoded(webrtc::VideoFrame& decodedImage, - int64_t decode_time_ms) override { + int32_t Decoded(VideoFrame& /* decodedImage */) override { return 0; } + int32_t Decoded(webrtc::VideoFrame& /* decodedImage */, + int64_t /* decode_time_ms */) override { RTC_DCHECK_NOTREACHED(); return -1; } - void Decoded(webrtc::VideoFrame& decodedImage, - std::optional decode_time_ms, - std::optional qp) override { + void Decoded(webrtc::VideoFrame& /* decodedImage */, + std::optional /* decode_time_ms */, + std::optional /* qp */) override { RTC_DCHECK_NOTREACHED(); } } callback; diff --git a/api/video_codecs/test/video_encoder_factory_template_tests.cc b/api/video_codecs/test/video_encoder_factory_template_tests.cc index cf254cefe1..e473297f17 100644 --- a/api/video_codecs/test/video_encoder_factory_template_tests.cc +++ b/api/video_codecs/test/video_encoder_factory_template_tests.cc @@ -50,8 +50,8 @@ struct FooEncoderTemplateAdapter { static std::vector SupportedFormats() { return {kFooSdp}; } static std::unique_ptr CreateEncoder( - const Environment& env, - const SdpVideoFormat& format) { + const Environment& /* env */, + const SdpVideoFormat& /* format */) { return std::make_unique>(); } @@ -67,7 +67,7 @@ struct BarEncoderTemplateAdapter { } static std::unique_ptr CreateEncoder( - const Environment& env, + const Environment& /* env */, const SdpVideoFormat& format) { return std::make_unique>(); }