admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tolerate very large deltas in abs-capture-timestamp

Browse Source 
Cases above 100 ms have been observed on mac; use 60 seconds as
an offset.

Bug: webrtc:380712819
Change-Id: I52a085cb196472188bb5493276a1b32524717c1f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/369881
Auto-Submit: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Olga Sharonova <olka@webrtc.org>
Commit-Queue: Olga Sharonova <olka@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43473}
This commit is contained in:
Harald Alvestrand 2024-11-29 10:27:06 +00:00 committed by WebRTC LUCI CQ
parent 934c983404
commit 8d085422ed
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pc/peer_connection_integrationtest.cc
View File

@ -4286,8 +4286,9 @@ TEST_F(PeerConnectionIntegrationTestUnifiedPlan,
ASSERT_TRUE_WAIT(
metrics::NumSamples("WebRTC.Call.AbsCapture.ExtensionWait") > 0,
kDefaultTimeout);
// Observed deltas are up to 37 msec. Allow 100 msec.
EXPECT_LT(metrics::MinSample("WebRTC.Call.AbsCapture.Delta"), 100'000);
// Observed deltas are more than 100 msec. Use 1 minute as tolerance;
// this is a check against wrong timebase.
EXPECT_LT(metrics::MinSample("WebRTC.Call.AbsCapture.Delta"), 60'000'000);
ASSERT_TRUE_WAIT(metrics::NumSamples("WebRTC.Call.AbsCapture.OffsetWait") > 0,
kDefaultTimeout);
// On a point-to-point call, we expect the offset to be zero.