From 8d085422ed9d8ce684c4dc4fc1f95edc18743356 Mon Sep 17 00:00:00 2001 From: Harald Alvestrand Date: Fri, 29 Nov 2024 10:27:06 +0000 Subject: [PATCH] Tolerate very large deltas in abs-capture-timestamp Cases above 100 ms have been observed on mac; use 60 seconds as an offset. Bug: webrtc:380712819 Change-Id: I52a085cb196472188bb5493276a1b32524717c1f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/369881 Auto-Submit: Harald Alvestrand Reviewed-by: Olga Sharonova Commit-Queue: Olga Sharonova Cr-Commit-Position: refs/heads/main@{#43473} --- pc/peer_connection_integrationtest.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pc/peer_connection_integrationtest.cc b/pc/peer_connection_integrationtest.cc index fb66fa9743..cf083895b8 100644 --- a/pc/peer_connection_integrationtest.cc +++ b/pc/peer_connection_integrationtest.cc @@ -4286,8 +4286,9 @@ TEST_F(PeerConnectionIntegrationTestUnifiedPlan, ASSERT_TRUE_WAIT( metrics::NumSamples("WebRTC.Call.AbsCapture.ExtensionWait") > 0, kDefaultTimeout); - // Observed deltas are up to 37 msec. Allow 100 msec. - EXPECT_LT(metrics::MinSample("WebRTC.Call.AbsCapture.Delta"), 100'000); + // Observed deltas are more than 100 msec. Use 1 minute as tolerance; + // this is a check against wrong timebase. + EXPECT_LT(metrics::MinSample("WebRTC.Call.AbsCapture.Delta"), 60'000'000); ASSERT_TRUE_WAIT(metrics::NumSamples("WebRTC.Call.AbsCapture.OffsetWait") > 0, kDefaultTimeout); // On a point-to-point call, we expect the offset to be zero.