admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Grant CQ+2 access to project-webrtc-submit-access.

Browse Source 
The reason we are doing this is because the "committers" group grants access to Code-Review, and we now have a policy that such groups must only contain direct human users. However, we still want robot accounts to be able to CQ+2, so we now have the -submit-access group that includes anyone who can CQ+2, not just committers.

Bug: chromium:356276684
Change-Id: I39c3b92110ff10f53a2825f5e12690580331364d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/363480
Reviewed-by: Christoffer Dewerin <jansson@webrtc.org>
Auto-Submit: Joey Scarr <jsca@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43073}
This commit is contained in:
Joey Scarr 2024-09-24 02:52:57 +00:00 committed by WebRTC LUCI CQ
parent 7398d10a5a
commit 8ab5483dcb
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
infra/config/commit-queue.cfg
View File

@ -22,7 +22,7 @@ config_groups {
} }
verifiers { verifiers {
gerrit_cq_ability { gerrit_cq_ability {
committer_list: "project-webrtc-committers" committer_list: "project-webrtc-submit-access"
dry_run_access_list: "project-webrtc-tryjob-access" dry_run_access_list: "project-webrtc-tryjob-access"
allow_owner_if_submittable: DRY_RUN allow_owner_if_submittable: DRY_RUN
} }
@ -223,7 +223,7 @@ config_groups {
} }
verifiers { verifiers {
gerrit_cq_ability { gerrit_cq_ability {
committer_list: "project-webrtc-committers" committer_list: "project-webrtc-submit-access"
dry_run_access_list: "project-webrtc-tryjob-access" dry_run_access_list: "project-webrtc-tryjob-access"
} }
tryjob { tryjob {

4
infra/config/config.star
View File

@ -315,7 +315,7 @@ luci.cq_group(
tree_status_host = "webrtc-status.appspot.com", tree_status_host = "webrtc-status.appspot.com",
watch = [cq.refset(repo = WEBRTC_GERRIT, refs = ["refs/heads/main"])], watch = [cq.refset(repo = WEBRTC_GERRIT, refs = ["refs/heads/main"])],
acls = [ acls = [
acl.entry(acl.CQ_COMMITTER, groups = ["project-webrtc-committers"]), acl.entry(acl.CQ_COMMITTER, groups = ["project-webrtc-submit-access"]),
acl.entry(acl.CQ_DRY_RUNNER, groups = ["project-webrtc-tryjob-access"]), acl.entry(acl.CQ_DRY_RUNNER, groups = ["project-webrtc-tryjob-access"]),
], ],
allow_owner_if_submittable = cq.ACTION_DRY_RUN, allow_owner_if_submittable = cq.ACTION_DRY_RUN,
@ -327,7 +327,7 @@ luci.cq_group(
name = "cq_branch", name = "cq_branch",
watch = [cq.refset(repo = WEBRTC_GERRIT, refs = ["refs/branch-heads/.+"])], watch = [cq.refset(repo = WEBRTC_GERRIT, refs = ["refs/branch-heads/.+"])],
acls = [ acls = [
acl.entry(acl.CQ_COMMITTER, groups = ["project-webrtc-committers"]), acl.entry(acl.CQ_COMMITTER, groups = ["project-webrtc-submit-access"]),
acl.entry(acl.CQ_DRY_RUNNER, groups = ["project-webrtc-tryjob-access"]), acl.entry(acl.CQ_DRY_RUNNER, groups = ["project-webrtc-tryjob-access"]),
], ],
retry_config = cq.RETRY_ALL_FAILURES, retry_config = cq.RETRY_ALL_FAILURES,

2
infra/config/project.cfg
View File

@ -7,7 +7,7 @@
name: "webrtc" name: "webrtc"
access: "group:all" access: "group:all"
lucicfg { lucicfg {
version: "1.43.12" version: "1.43.13"
package_dir: "." package_dir: "."
config_dir: "." config_dir: "."
entry_point: "config.star" entry_point: "config.star"