From 8ab5483dcb11b31a763c18abb982fe187a766e34 Mon Sep 17 00:00:00 2001 From: Joey Scarr Date: Tue, 24 Sep 2024 02:52:57 +0000 Subject: [PATCH] Grant CQ+2 access to project-webrtc-submit-access. The reason we are doing this is because the "committers" group grants access to Code-Review, and we now have a policy that such groups must only contain direct human users. However, we still want robot accounts to be able to CQ+2, so we now have the -submit-access group that includes anyone who can CQ+2, not just committers. Bug: chromium:356276684 Change-Id: I39c3b92110ff10f53a2825f5e12690580331364d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/363480 Reviewed-by: Christoffer Dewerin Auto-Submit: Joey Scarr Reviewed-by: Mirko Bonadei Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#43073} --- infra/config/commit-queue.cfg | 4 ++-- infra/config/config.star | 4 ++-- infra/config/project.cfg | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/infra/config/commit-queue.cfg b/infra/config/commit-queue.cfg index 7efd3996cc..6a3580a159 100644 --- a/infra/config/commit-queue.cfg +++ b/infra/config/commit-queue.cfg @@ -22,7 +22,7 @@ config_groups { } verifiers { gerrit_cq_ability { - committer_list: "project-webrtc-committers" + committer_list: "project-webrtc-submit-access" dry_run_access_list: "project-webrtc-tryjob-access" allow_owner_if_submittable: DRY_RUN } @@ -223,7 +223,7 @@ config_groups { } verifiers { gerrit_cq_ability { - committer_list: "project-webrtc-committers" + committer_list: "project-webrtc-submit-access" dry_run_access_list: "project-webrtc-tryjob-access" } tryjob { diff --git a/infra/config/config.star b/infra/config/config.star index 560da35297..742439fc58 100755 --- a/infra/config/config.star +++ b/infra/config/config.star @@ -315,7 +315,7 @@ luci.cq_group( tree_status_host = "webrtc-status.appspot.com", watch = [cq.refset(repo = WEBRTC_GERRIT, refs = ["refs/heads/main"])], acls = [ - acl.entry(acl.CQ_COMMITTER, groups = ["project-webrtc-committers"]), + acl.entry(acl.CQ_COMMITTER, groups = ["project-webrtc-submit-access"]), acl.entry(acl.CQ_DRY_RUNNER, groups = ["project-webrtc-tryjob-access"]), ], allow_owner_if_submittable = cq.ACTION_DRY_RUN, @@ -327,7 +327,7 @@ luci.cq_group( name = "cq_branch", watch = [cq.refset(repo = WEBRTC_GERRIT, refs = ["refs/branch-heads/.+"])], acls = [ - acl.entry(acl.CQ_COMMITTER, groups = ["project-webrtc-committers"]), + acl.entry(acl.CQ_COMMITTER, groups = ["project-webrtc-submit-access"]), acl.entry(acl.CQ_DRY_RUNNER, groups = ["project-webrtc-tryjob-access"]), ], retry_config = cq.RETRY_ALL_FAILURES, diff --git a/infra/config/project.cfg b/infra/config/project.cfg index 53615b4c2a..b3f6b9a43c 100644 --- a/infra/config/project.cfg +++ b/infra/config/project.cfg @@ -7,7 +7,7 @@ name: "webrtc" access: "group:all" lucicfg { - version: "1.43.12" + version: "1.43.13" package_dir: "." config_dir: "." entry_point: "config.star"