admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add default values for SimulcastStream members

Browse Source 
The default values are zero, for consistency with the memset of VideoCodec. Except for numberOfTemporalLayers; This cl sets
numberOfTemporalLayers to 1 by default. The intention is to be able to
delete exlpicit setting of .numberOfTemporalLayers = 1 in downstream
code, to ease replacing it with a scalability mode.

Bug: webrtc:11607
Change-Id: I9de442f1893d474ea360f9b33364a00627f6c3be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267662
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37430}
This commit is contained in:
Niels Möller 2022-07-04 17:16:52 +02:00 committed by WebRTC LUCI CQ
parent 56257afe10
commit 865e45d14e
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
api/video_codecs/simulcast_stream.h
View File

@ -16,15 +16,15 @@ namespace webrtc {
// TODO(bugs.webrtc.org/6883): Unify with struct VideoStream, part of
// VideoEncoderConfig.
struct SimulcastStream {
int width;
int height;
float maxFramerate; // fps.
unsigned char numberOfTemporalLayers;
unsigned int maxBitrate; // kilobits/sec.
unsigned int targetBitrate; // kilobits/sec.
unsigned int minBitrate; // kilobits/sec.
unsigned int qpMax; // minimum quality
bool active; // encoded and sent.
int width = 0;
int height = 0;
float maxFramerate = 0; // fps.
unsigned char numberOfTemporalLayers = 1;
unsigned int maxBitrate = 0; // kilobits/sec.
unsigned int targetBitrate = 0; // kilobits/sec.
unsigned int minBitrate = 0; // kilobits/sec.
unsigned int qpMax = 0; // minimum quality
bool active = false; // encoded and sent.
};
} // namespace webrtc