From 865e45d14e0013272ee77dd14e3489b3d6f49048 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Mon, 4 Jul 2022 17:16:52 +0200 Subject: [PATCH] Add default values for SimulcastStream members MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The default values are zero, for consistency with the memset of VideoCodec. Except for numberOfTemporalLayers; This cl sets numberOfTemporalLayers to 1 by default. The intention is to be able to delete exlpicit setting of .numberOfTemporalLayers = 1 in downstream code, to ease replacing it with a scalability mode. Bug: webrtc:11607 Change-Id: I9de442f1893d474ea360f9b33364a00627f6c3be Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267662 Reviewed-by: Erik Språng Commit-Queue: Niels Moller Cr-Commit-Position: refs/heads/main@{#37430} --- api/video_codecs/simulcast_stream.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/api/video_codecs/simulcast_stream.h b/api/video_codecs/simulcast_stream.h index 79a9395d26..578275b852 100644 --- a/api/video_codecs/simulcast_stream.h +++ b/api/video_codecs/simulcast_stream.h @@ -16,15 +16,15 @@ namespace webrtc { // TODO(bugs.webrtc.org/6883): Unify with struct VideoStream, part of // VideoEncoderConfig. struct SimulcastStream { - int width; - int height; - float maxFramerate; // fps. - unsigned char numberOfTemporalLayers; - unsigned int maxBitrate; // kilobits/sec. - unsigned int targetBitrate; // kilobits/sec. - unsigned int minBitrate; // kilobits/sec. - unsigned int qpMax; // minimum quality - bool active; // encoded and sent. + int width = 0; + int height = 0; + float maxFramerate = 0; // fps. + unsigned char numberOfTemporalLayers = 1; + unsigned int maxBitrate = 0; // kilobits/sec. + unsigned int targetBitrate = 0; // kilobits/sec. + unsigned int minBitrate = 0; // kilobits/sec. + unsigned int qpMax = 0; // minimum quality + bool active = false; // encoded and sent. }; } // namespace webrtc